fix: update perDay & totalMax defaults (#893)

* fix: update perDay & totalMax defaults * fix: tests
brave · Sep 21, 2023 · 23a7efe · 23a7efe
1 parent 6034f53
commit 23a7efe
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/user/library/index.test.ts b/src/user/library/index.test.ts
@@ -283,14 +283,14 @@ describe("new form tests", () => {
                 "name": "macos",
               },
             ],
-            "perDay": 1,
+            "perDay": 4,
             "segments": [
               {
                 "code": "5678",
                 "name": "test",
               },
             ],
-            "totalMax": 10,
+            "totalMax": 28,
           },
         ],
         "advertiserId": "12345",

diff --git a/src/user/library/index.ts b/src/user/library/index.ts
@@ -53,10 +53,10 @@ export function transformNewForm(
     adSets: form.adSets.map((adSet) => ({
       name: adSet.name,
       billingType: form.billingType,
-      perDay: 1,
+      perDay: form.format === CampaignFormat.PushNotification ? 4 : 6,
       segments: adSet.segments.map((s) => ({ code: s.code, name: s.name })),
       oses: adSet.oses,
-      totalMax: 10,
+      totalMax: form.format === CampaignFormat.PushNotification ? 28 : 60,
       conversions: transformConversion(adSet.conversions),
       ads: adSet.creatives
         .filter((c) => c.included)