Skip to content

Commit

Permalink
Merge pull request #1114 from brave/master
Browse files Browse the repository at this point in the history
Production Release 2024-03-07
  • Loading branch information
IanKrieger authored Mar 7, 2024
2 parents 6493918 + 574a5c5 commit 86955d2
Show file tree
Hide file tree
Showing 43 changed files with 1,571 additions and 1,223 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@47b3d888fe66b639e431abf22ebca059152f1eea # v3.24.5
uses: github/codeql-action/init@8a470fddafa5cbb6266ee11b37ef4d8aae19c571 # v3.24.6
with:
languages: ${{ matrix.language }}
# If you wish to specify custom queries, you can do so here or in a config file.
Expand All @@ -53,7 +53,7 @@ jobs:
# Autobuild attempts to build any compiled languages (C/C++, C#, or Java).
# If this step fails, then you should remove it and run the build manually (see below)
- name: Autobuild
uses: github/codeql-action/autobuild@47b3d888fe66b639e431abf22ebca059152f1eea # v3.24.5
uses: github/codeql-action/autobuild@8a470fddafa5cbb6266ee11b37ef4d8aae19c571 # v3.24.6

# ℹ️ Command-line programs to run using the OS shell.
# 📚 https://git.io/JvXDl
Expand All @@ -67,4 +67,4 @@ jobs:
# make release

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@47b3d888fe66b639e431abf22ebca059152f1eea # v3.24.5
uses: github/codeql-action/analyze@8a470fddafa5cbb6266ee11b37ef4d8aae19c571 # v3.24.6
7 changes: 4 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,15 @@ You may need to proceed through a certificate warning in order to develop locall
```

## Localization
After changing text, o adding new translated text you need to run:

After changing text, or adding new translated text you need to run:

```
❯ npm run extract
```

THe output should look something like:

```
> ads-ui@0.1.0 extract
> lingui extract
Expand All @@ -61,5 +64,3 @@ Once translations are complete, they should be added to the `msgstr` portion of

To add more locales, edit the `locales` array in `lingui.config.js` and run `npm run extract` again.
Make sure you also update `i18n.ts` with the new locale.


12 changes: 12 additions & 0 deletions brave-icon-release-color.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading

0 comments on commit 86955d2

Please sign in to comment.