Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Production Release 2024-07-30 #1281

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Production Release 2024-07-30 #1281

merged 3 commits into from
Jul 30, 2024

Conversation

Replace old update mutations with ones that make it far more clear
exactly what you are updating when editing a creative
…1279)

As we transition to new mutations, some discrepancies can pop up. This
is one of them.
@IanKrieger IanKrieger requested a review from a team as a code owner July 29, 2024 16:18
@github-actions github-actions bot changed the title Prod Release (Next) Production Release 2024-07-29 Jul 29, 2024
@github-actions github-actions bot changed the title Production Release 2024-07-29 Production Release 2024-07-30 Jul 30, 2024
tackley
tackley previously approved these changes Jul 30, 2024
Copy link

[puLL-Merge] - brave/ads-ui@1281

Description

This PR updates the Creative management functionality in the Brave Ads UI. It introduces new GraphQL mutations for updating creative state and payload, removes the old update mutation, and modifies the related components to use these new mutations. The PR also includes some minor changes to localization files and the key pair modal.

Changes

Changes

  1. src/components/Creatives/CreativeStatusSwitch.tsx:

    • Replaced UpdateCreativeDocument with a new Creative_State_Update mutation
    • Updated the mutation call to use the new structure
    • Removed unnecessary refetch query for campaigns
  2. src/components/Creatives/hooks/useSubmitCreative.tsx:

    • Replaced UpdateCreativeDocument with a new Update_Creative_Payload mutation
    • Updated the mutation call to use the new input structure
    • Removed dimensions from the payload when updating
  3. src/graphql-client/gql.ts and src/graphql-client/graphql.ts:

    • Added new types and documents for the new mutations
    • Removed the old UpdateCreativeDocument
  4. src/graphql/ads-serve.graphql.schema.json:

    • Added new input types for the new mutations
    • Removed userId field from various input types
    • Removed stripePaymentId from UpdateCampaignInput
  5. src/graphql/creative.graphql:

    • Removed the UpdateCreative mutation
  6. src/locales/*.po:

    • Updated translation for "Your account's new public key will be:" to "Your account's new private key will be:"
  7. src/user/settings/NewKeyPairModal.tsx:

    • Changed the text from "public key" to "private key" in the modal

Possible Issues

  • The removal of the dimensions field when updating creatives might cause issues if this field is required or used elsewhere in the application.
  • The change from "public key" to "private key" in the NewKeyPairModal might be confusing for users if it's not accompanied by appropriate documentation or UI changes.

Security Hotspots

  • The change from displaying a public key to a private key in the NewKeyPairModal could potentially expose sensitive information. Ensure that this change is intentional and that proper security measures are in place to protect the private key.

@IanKrieger IanKrieger added this pull request to the merge queue Jul 30, 2024
Merged via the queue into prod with commit da333b4 Jul 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants