Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Production Release 2024-10-08 #1366

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Production Release 2024-10-08 #1366

merged 4 commits into from
Oct 8, 2024

Conversation

IanKrieger
Copy link
Member

@IanKrieger IanKrieger commented Oct 7, 2024 •
edited by github-actions bot
Loading

renovate bot and others added 4 commits October 2, 2024 12:04
@renovate
chore(deps): update all non-major dependencies (#1362)
e238c1b 
This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[@types/react](https://redirect.github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react)
([source](https://redirect.github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react))
| [`18.3.9` ->
`18.3.10`](https://renovatebot.com/diffs/npm/@types%2freact/18.3.9/18.3.10)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@types%2freact/18.3.10?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@types%2freact/18.3.10?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@types%2freact/18.3.9/18.3.10?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@types%2freact/18.3.9/18.3.10?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
|
[eslint-plugin-react](https://redirect.github.com/jsx-eslint/eslint-plugin-react)
| [`7.36.1` ->
`7.37.0`](https://renovatebot.com/diffs/npm/eslint-plugin-react/7.36.1/7.37.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/eslint-plugin-react/7.37.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/eslint-plugin-react/7.37.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/eslint-plugin-react/7.36.1/7.37.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/eslint-plugin-react/7.36.1/7.37.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [knip](https://knip.dev)
([source](https://redirect.github.com/webpro-nl/knip/tree/HEAD/packages/knip))
| [`5.30.5` ->
`5.30.6`](https://renovatebot.com/diffs/npm/knip/5.30.5/5.30.6) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/knip/5.30.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/knip/5.30.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/knip/5.30.5/5.30.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/knip/5.30.5/5.30.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>jsx-eslint/eslint-plugin-react (eslint-plugin-react)</summary>

###
[`v7.37.0`](https://redirect.github.com/jsx-eslint/eslint-plugin-react/blob/HEAD/CHANGELOG.md#7370---20240926)

[Compare
Source](https://redirect.github.com/jsx-eslint/eslint-plugin-react/compare/v7.36.1...v7.37.0)

##### Added

- add type generation ([#&#8203;3830][]
[@&#8203;voxpelli](https://redirect.github.com/voxpelli))
- \[`no-unescaped-entities`]: add suggestions ([#&#8203;3831][]
[@&#8203;StyleShit](https://redirect.github.com/StyleShit))
- \[`forbid-component-props`]: add
`allowedForPatterns`/`disallowedForPatterns` options ([#&#8203;3805][]
[@&#8203;Efimenko](https://redirect.github.com/Efimenko))
- \[`no-unstable-nested-components`]: add `propNamePattern` to support
custom render prop naming conventions ([#&#8203;3826][]
[@&#8203;danreeves](https://redirect.github.com/danreeves))

##### Changed

- \[readme] flat config example for react 17+ ([#&#8203;3824][]
[@&#8203;GabenGar](https://redirect.github.com/GabenGar))

[7.36.2]:
https://redirect.github.com/jsx-eslint/eslint-plugin-react/compare/v7.36.1...v7.36.2

[#&#8203;3831]:
https://redirect.github.com/jsx-eslint/eslint-plugin-react/pull/3831

[#&#8203;3830]:
https://redirect.github.com/jsx-eslint/eslint-plugin-react/pull/3830

[#&#8203;3826]:
https://redirect.github.com/jsx-eslint/eslint-plugin-react/pull/3826

[#&#8203;3824]:
https://redirect.github.com/jsx-eslint/eslint-plugin-react/pull/3824

[#&#8203;3805]:
https://redirect.github.com/jsx-eslint/eslint-plugin-react/pull/3805

</details>

<details>
<summary>webpro-nl/knip (knip)</summary>

###
[`v5.30.6`](https://redirect.github.com/webpro-nl/knip/releases/tag/5.30.6)

[Compare
Source](https://redirect.github.com/webpro-nl/knip/compare/5.30.5...5.30.6)

- Ignore TS issue with Bun for now
([`2a36139`](https://redirect.github.com/webpro-nl/knip/commit/2a361399))
- Add --trace arguments to help text
([`4b314e2`](https://redirect.github.com/webpro-nl/knip/commit/4b314e2a))
- accept \_ and . in package names
([#&#8203;790](https://redirect.github.com/webpro-nl/knip/issues/790))
([`84db245`](https://redirect.github.com/webpro-nl/knip/commit/84db2459))
- Remove duplicate job (it's in integration.yml as well)
([`2b550b0`](https://redirect.github.com/webpro-nl/knip/commit/2b550b0f))
- continue-on-error: true → fail-fast: false
([`8ed9314`](https://redirect.github.com/webpro-nl/knip/commit/8ed9314c))
- Update argos ci commands
([`ed4bad2`](https://redirect.github.com/webpro-nl/knip/commit/ed4bad21))
- Add freeCodeCamp to integration suite
([`0784ca5`](https://redirect.github.com/webpro-nl/knip/commit/0784ca5f))
- Update FUNDING.yml
([`cf6c5fe`](https://redirect.github.com/webpro-nl/knip/commit/cf6c5fe8))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "* 0-4 * * 3" (UTC), Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config
help](https://redirect.github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/brave/ads-ui).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC45Ny4wIiwidXBkYXRlZEluVmVyIjoiMzguOTcuMCIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@IanKrieger
chore(graphql): update codegen (#1363)
59cb592
@IanKrieger
feat(account balance): add functionality to close campaigns and trans…
56fc83f 
…fer balance (#1356)

Allows for a user to close their campaign, and attribute the funds to a
different campaign.

This is the second to last step in:
brave/ads-serve#4050
@IanKrieger
fix: account balance wording (#1365)
455c003 
Better wording
@IanKrieger IanKrieger requested review from tackley and a team as code owners October 7, 2024 12:34
@github-actions github-actions bot changed the title Prod Release (NEXT) Production Release 2024-10-07 Oct 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

[puLL-Merge] - brave/ads-ui@1366

Description

This PR introduces a new feature allowing users to close campaigns and manage account balances. It adds a "Close Campaign" button for eligible campaigns, displays the advertiser's account balance, and updates the payment method field to show account balance information when creating or editing campaigns.

Changes

Changes

  1. CloseCampaignModal.tsx:

    • New component for closing campaigns
    • Implements a modal with confirmation dialog

  2. CampaignList.tsx:

    • Added CloseCampaignModal to the campaign list for eligible advertisers

  3. useGetAdvertiserAccountBalance.tsx:

    • New hook to fetch the advertiser's account balance

  4. AccountBalance.tsx:

    • New component to display the advertiser's account balance

  5. Settings.tsx:

    • Added AccountBalance component to the settings page

  6. PaymentMethodField.tsx:

    • Updated to show account balance information when creating/editing campaigns
    • Added logic to calculate and display the amount to be charged

  7. graphql.ts and graphql.schema.json:

    • Updated GraphQL types and schema to include new fields like adsManagerCurrentBalance and hasInProcessOrCompleteTransfer

  8. Localization files:

    • Added new strings for the new features in various language files

Possible Issues

  1. The account balance fetching might cause additional API calls, which could impact performance if not properly optimized.
  2. The UI changes in the payment method field might be confusing for users who are not familiar with the new account balance feature.

Security Hotspots

No significant security issues were identified in this PR. However, it's important to ensure that:

  1. The account balance information is properly protected and only accessible to authorized users.
  2. The campaign closing functionality is properly secured to prevent unauthorized closures.

@github-actions github-actions bot changed the title Production Release 2024-10-07 Production Release 2024-10-08 Oct 8, 2024
@IanKrieger IanKrieger added this pull request to the merge queue Oct 8, 2024
Merged via the queue into prod with commit f9dd624 Oct 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tackley tackley tackley approved these changes

Assignees
No one assigned
Labels
depends-on-server-release puLL-Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IanKrieger @tackley