Production Release 2024-11-22

[tackley]

Features

• feat(payments): allow for budget increases #1395

Fixes

• fix: extract recent translations #1400

Chores

• chore(deps): update all non-major dependencies #1396
• chore: remove Ian from CODEOWNERS #1398

[github-actions]

[puLL-Merge] - brave/ads-ui@1399

Description

This PR introduces a new feature to increase the budget for existing campaigns. It adds a new "Increase Budget" button next to the budget field for campaigns that are not in draft mode and where the advertiser doesn't have self-service price setting enabled. The feature includes a new dialog for entering the additional budget amount and a new API call to the backend to process the budget increase.

Changes

Changes

1. src/checkout/hooks/useIncreaseCampaignBudget.ts:

   • New hook for handling the budget increase process.

2. src/checkout/lib/index.ts:

   • Added new increaseCampaignBudget function to make API call to the backend.

3. src/user/views/adsManager/views/advanced/components/campaign/fields/BudgetField.tsx:

   • Modified BudgetField component to include the new "Increase Budget" button.
   • Added new IncreaseBudgetDialog component for the budget increase dialog.

sequenceDiagram
    actor User
    participant BudgetField
    participant IncreaseBudgetDialog
    participant useIncreaseCampaignBudget
    participant API
    participant Backend

    User->>BudgetField: View campaign budget
    BudgetField->>IncreaseBudgetDialog: Click "Increase Budget"
    IncreaseBudgetDialog->>User: Enter additional budget amount
    User->>IncreaseBudgetDialog: Confirm increase
    IncreaseBudgetDialog->>useIncreaseCampaignBudget: Call hook
    useIncreaseCampaignBudget->>API: Call increaseCampaignBudget
    API->>Backend: Send increase request
    Backend->>API: Return payment session URL
    API->>useIncreaseCampaignBudget: Return URL
    useIncreaseCampaignBudget->>User: Redirect to payment page

Loading

graph TD
    A[BudgetField] --> B[IncreaseBudgetDialog]
    B --> C[useIncreaseCampaignBudget]
    C --> D[increaseCampaignBudget API]
    D --> E[Backend Server]

Loading

Possible Issues

• The error handling in the useIncreaseCampaignBudget hook uses alert() for displaying errors, which is not ideal for production applications. Consider using a more user-friendly notification system.
• The IncreaseBudgetDialog component doesn't handle non-numeric input for the amount field, which could lead to potential bugs.

Security Hotspots

1. src/checkout/lib/index.ts:
   • The increaseCampaignBudget function sends sensitive information (advertiser ID, campaign ID, and amount) to the server. Ensure that this endpoint is properly secured and authenticated.