Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: introduce eslint #857

Merged
merged 2 commits into from
Aug 11, 2023
Merged

chore: introduce eslint #857

merged 2 commits into from
Aug 11, 2023

Conversation

IanKrieger
Copy link
Member

@IanKrieger IanKrieger commented Aug 11, 2023 •
edited
Loading

Adds eslint and fixes errors without changing any logic

@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
eslint-config-prettier 9.0.0 environment +6 2.77 MB lydell

tackley
tackley reviewed Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@tackley tackley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks excellent, other than the fact I think all your lsquo's should be rsquo's.

src/auth/registration/AddressField.tsx Outdated Show resolved Hide resolved
src/auth/registration/NameField.tsx Outdated Show resolved Hide resolved
@IanKrieger IanKrieger merged commit fd1e50a into master Aug 11, 2023
7 checks passed
@IanKrieger IanKrieger deleted the c/eslint branch August 11, 2023 16:05
@IanKrieger IanKrieger mentioned this pull request Aug 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tackley tackley tackley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IanKrieger @tackley