Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: generalize how ads are created #863

Merged
merged 22 commits into from
Aug 29, 2023
Merged

chore: generalize how ads are created #863

merged 22 commits into from
Aug 29, 2023

Commits on Aug 29, 2023

  1. feat: allow use of existing creatives

    @IanKrieger
    IanKrieger committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    32bce26 View commit details
    Browse the repository at this point in the history

  2. fix: tests

    @IanKrieger
    IanKrieger committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    a36a9a8 View commit details
    Browse the repository at this point in the history

  3. feat: add new creative form

    @IanKrieger
    IanKrieger committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    cf0edf4 View commit details
    Browse the repository at this point in the history

  4. feat: add existing creative modals to campaign create

    @IanKrieger
    IanKrieger committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    44ac813 View commit details
    Browse the repository at this point in the history

  5. fix: remove in sync

    @IanKrieger
    IanKrieger committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    4b7d60c View commit details
    Browse the repository at this point in the history

  6. chore: move away from notification specific code

    @IanKrieger
    IanKrieger committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    6897f6a View commit details
    Browse the repository at this point in the history

  7. chore: prepare for non-specific creative types

    @IanKrieger
    IanKrieger committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    cc8133e View commit details
    Browse the repository at this point in the history

  8. chore: be more deliberate about populating form values

    @IanKrieger
    IanKrieger committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    1600df4 View commit details
    Browse the repository at this point in the history

  9. fix: pick another field

    @IanKrieger
    IanKrieger committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    1050c32 View commit details
    Browse the repository at this point in the history

  10. fix: better convert fragments

    @IanKrieger
    IanKrieger committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    8ff01c7 View commit details
    Browse the repository at this point in the history

  11. fix: reduce changes

    @IanKrieger
    IanKrieger committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    b908443 View commit details
    Browse the repository at this point in the history

  12. fix: merge conflict

    @IanKrieger
    IanKrieger committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    c9d292e View commit details
    Browse the repository at this point in the history

  13. fix: remove changes around edit

    @IanKrieger
    IanKrieger committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    0d34b3c View commit details
    Browse the repository at this point in the history

  14. fix: make sure edit knows they will lose changes

    @IanKrieger
    IanKrieger committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    3948c3c View commit details
    Browse the repository at this point in the history

  15. fix: dont prop-drill loading

    @IanKrieger
    IanKrieger committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    e7865bc View commit details
    Browse the repository at this point in the history

  16. fix: return component

    @IanKrieger
    IanKrieger committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    f32901a View commit details
    Browse the repository at this point in the history

  17. fix: bring back externalId

    @IanKrieger
    IanKrieger committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    031ef5e View commit details
    Browse the repository at this point in the history

  18. fix: keep a copy of the existing ad set creatives

    @IanKrieger
    IanKrieger committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    318624e View commit details
    Browse the repository at this point in the history

  19. fix: move creatives into one form backing object

    @IanKrieger
    IanKrieger committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    658989a View commit details
    Browse the repository at this point in the history

  20. fix: edit values

    @IanKrieger
    IanKrieger committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    0f91c51 View commit details
    Browse the repository at this point in the history

  21. fix: working index means no id necessary

    @IanKrieger
    IanKrieger committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    284eecd View commit details
    Browse the repository at this point in the history

  22. fix: add tests and adjust padding

    @IanKrieger
    IanKrieger committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    80c83b9 View commit details
    Browse the repository at this point in the history