Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support reporting on CPV campaigns #864

Merged
merged 2 commits into from
Aug 17, 2023
Merged

feat: support reporting on CPV campaigns #864

merged 2 commits into from
Aug 17, 2023

Commits on Aug 17, 2023

  1. feat: support reporting on CPV campaigns 

    Correctly report the billing type for CPV campaigns, and do not break if additional billng types are added in the future.

However, intentionally we do not yet support this billing type for self-service created campaigns.

Re brave/ads-serve#3255
    @tackley
    tackley committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    1b2d1c2 View commit details
    Browse the repository at this point in the history

  2. Update based on review feedback

    @tackley
    tackley committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    dc3465d View commit details
    Browse the repository at this point in the history