Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support news ads #876

Merged
merged 11 commits into from
Sep 6, 2023
Merged

feat: support news ads #876

merged 11 commits into from
Sep 6, 2023

Conversation

IanKrieger
Copy link
Member

@IanKrieger IanKrieger commented Aug 29, 2023

Supports the creation of news ads in self-service


Screenshare.-.2023-08-31.1_31_11.PM.mp4

Screen Shot 2023-08-31 at 2 00 50 PM

@IanKrieger IanKrieger requested review from OdoCecII and a team August 31, 2023 18:03
@IanKrieger IanKrieger marked this pull request as ready for review August 31, 2023 18:03
Copy link
Collaborator

@tackley tackley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - make sure the approval side in ads-admin is all good before releasing to prod :)

@IanKrieger IanKrieger merged commit fa01f8d into master Sep 6, 2023
7 checks passed
@IanKrieger IanKrieger deleted the f/news branch September 6, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants