Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Production Release 2023-09-06 #877

Merged
merged 4 commits into from
Sep 6, 2023
Merged

Production Release 2023-09-06 #877

merged 4 commits into from
Sep 6, 2023

Conversation

IanKrieger and others added 2 commits August 29, 2023 14:42
* feat: allow use of existing creatives

* fix: tests

* feat: add new creative form

* feat: add existing creative modals to campaign create

* fix: remove in sync

* chore: move away from notification specific code

* chore: prepare for non-specific creative types

* chore: be more deliberate about populating form values

* fix: pick another field

* fix: better convert fragments

* fix: reduce changes

* fix: merge conflict

* fix: remove changes around edit

* fix: make sure edit knows they will lose changes

* fix: dont prop-drill loading

* fix: return component

* fix: bring back externalId

* fix: keep a copy of the existing ad set creatives

* fix: move creatives into one form backing object

* fix: edit values

* fix: working index means no id necessary

* fix: add tests and adjust padding
* fix(deps): update all non-major dependencies

* fix: switch adapters

* fix: re-rerun install

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Ian Krieger <iandkrieger@gmail.com>
@IanKrieger IanKrieger temporarily deployed to staging September 1, 2023 13:59 — with GitHub Actions Inactive
@IanKrieger IanKrieger self-requested a review September 5, 2023 12:42
@IanKrieger IanKrieger changed the title Production Release (next) Production Release 2023-09-05 Sep 5, 2023
@IanKrieger IanKrieger marked this pull request as ready for review September 5, 2023 12:42
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@IanKrieger IanKrieger temporarily deployed to staging September 5, 2023 13:26 — with GitHub Actions Inactive
* fix: correctly include createdAt

* fix: update test
@IanKrieger IanKrieger temporarily deployed to staging September 5, 2023 18:02 — with GitHub Actions Inactive
@IanKrieger IanKrieger changed the title Production Release 2023-09-05 Production Release 2023-09-06 Sep 5, 2023
@IanKrieger IanKrieger added this pull request to the merge queue Sep 6, 2023
Merged via the queue into prod with commit 4ae62ff Sep 6, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants