-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Production Release 2023-09-06 #877
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: allow use of existing creatives * fix: tests * feat: add new creative form * feat: add existing creative modals to campaign create * fix: remove in sync * chore: move away from notification specific code * chore: prepare for non-specific creative types * chore: be more deliberate about populating form values * fix: pick another field * fix: better convert fragments * fix: reduce changes * fix: merge conflict * fix: remove changes around edit * fix: make sure edit knows they will lose changes * fix: dont prop-drill loading * fix: return component * fix: bring back externalId * fix: keep a copy of the existing ad set creatives * fix: move creatives into one form backing object * fix: edit values * fix: working index means no id necessary * fix: add tests and adjust padding
* fix(deps): update all non-major dependencies * fix: switch adapters * fix: re-rerun install --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Ian Krieger <iandkrieger@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* fix: correctly include createdAt * fix: update test
IanKrieger
approved these changes
Sep 5, 2023
IanKrieger
changed the title
Production Release 2023-09-05
Production Release 2023-09-06
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Chores