Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add VAC reporting #886

Merged
merged 12 commits into from
Sep 22, 2023
Merged

feat: add VAC reporting #886

merged 12 commits into from
Sep 22, 2023

Conversation

IanKrieger
Copy link
Member

@IanKrieger IanKrieger commented Sep 13, 2023

@IanKrieger IanKrieger marked this pull request as ready for review September 14, 2023 19:38
@IanKrieger IanKrieger requested a review from a team September 14, 2023 19:41
@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
papaparse 5.4.1 None +0 260 kB pokoli

Copy link

@bcaller bcaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security review looks good

src/user/reporting/ReportMenu.tsx Show resolved Hide resolved
src/user/reporting/ReportMenu.tsx Show resolved Hide resolved
src/user/reporting/ReportMenu.tsx Outdated Show resolved Hide resolved
src/user/reporting/csv.library.tsx Outdated Show resolved Hide resolved
@IanKrieger
Copy link
Member Author

@bcaller I went with the route of using a hidden input to accept the private key, instead of using react-state. This should keep the value in the DOM, and ephemeral in the way that once the dialogue component goes away, so does whatever value that used to be there.

@bcaller
Copy link

bcaller commented Sep 21, 2023

Ah OK, so hiding the dialog causes the input to be deleted and when you open the dialog again it's reinitialised. Good.

Copy link

@bcaller bcaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks

Copy link
Collaborator

@tackley tackley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@IanKrieger IanKrieger merged commit 4f256ba into master Sep 22, 2023
7 checks passed
@IanKrieger IanKrieger deleted the f/vac-reporting branch September 22, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants