feat: add VAC reporting #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanKrieger
force-pushed
the
f/vac-reporting
branch
from
847a3a2
to
59902d2
Compare
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
IanKrieger
force-pushed
the
f/vac-reporting
branch
from
92fa06d
to
3217904
Compare
|
@bcaller I went with the route of using a hidden input to accept the private key, instead of using react-state. This should keep the value in the DOM, and ephemeral in the way that once the dialogue component goes away, so does whatever value that used to be there. |
|
Ah OK, so hiding the dialog causes the input to be deleted and when you open the dialog again it's reinitialised. Good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Front end part of: https://github.com/brave/ads-serve/issues/1617
Demo located on: https://github.com/brave/ads-serve/pull/3352