Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate uncached name service lookups (ENS, SNS, UD) #33117

Closed
josheleonard opened this issue Sep 19, 2023 · 1 comment · Fixed by brave/brave-core#20219
Closed

Deprecate uncached name service lookups (ENS, SNS, UD) #33117

josheleonard opened this issue Sep 19, 2023 · 1 comment · Fixed by brave/brave-core#20219

Comments

@josheleonard
Copy link

josheleonard commented Sep 19, 2023

Description

We should cache results from name service address lookups to prevent refetching previous results

Steps to Reproduce

  1. Go to "Send" screen in wallet
  2. select ETH
  3. enter "vitalik.eth" as the "to" address
  4. edit the text to something else
  5. change the text back to "vitalik.eth"

Actual result:

address is refetched

Expected result:

address should appear without needing to fetch again (shouldn't see loading spinner)

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@srirambv
Copy link
Contributor

srirambv commented Nov 6, 2023

Verification passed on

Brave 1.61.61 Chromium: 119.0.6045.105 (Official Build) beta (64-bit)
Revision 6bbedb0b809f83b08334ffa36b1ea9df92e86245
OS Windows 11 Version 22H2 (Build 22621.2506)
  • Verified steps from brave/brave-core#20219
  • Verified ENS/SNS/UD domains address are cached and not re-fetched every time
33117.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants