Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: send screen performance refactor #20219

Merged
merged 23 commits into from
Oct 11, 2023
Merged

Fix: send screen performance refactor #20219

merged 23 commits into from
Oct 11, 2023

Conversation

josheleonard
Copy link
Contributor

@josheleonard josheleonard commented Sep 19, 2023 •
edited
Loading

Resolves brave/brave-browser#33117

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Send screen should continue to work as expected without regressions

@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels Sep 19, 2023
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@josheleonard josheleonard force-pushed the fix--send-screen-performance-refactor branch 2 times, most recently from 48662c9 to 7645f8a Compare September 19, 2023 15:19
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@josheleonard josheleonard force-pushed the fix--send-screen-performance-refactor branch from 7645f8a to 3860586 Compare September 19, 2023 21:13
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@josheleonard josheleonard force-pushed the fix--send-screen-performance-refactor branch from c9c8628 to 3e461d5 Compare September 21, 2023 14:52
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@josheleonard josheleonard force-pushed the fix--send-screen-performance-refactor branch 2 times, most recently from 71de9a1 to c88d43a Compare September 21, 2023 15:21
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@josheleonard josheleonard force-pushed the fix--send-screen-performance-refactor branch from 6518040 to f1f114a Compare September 21, 2023 16:19
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@josheleonard josheleonard force-pushed the fix--send-screen-performance-refactor branch from 60081cb to f26d529 Compare September 21, 2023 18:13
@josheleonard josheleonard marked this pull request as ready for review September 21, 2023 18:14
@josheleonard josheleonard requested a review from a team as a code owner September 21, 2023 18:14
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@josheleonard josheleonard force-pushed the fix--send-screen-performance-refactor branch from f26d529 to 5fccdd8 Compare September 21, 2023 21:02
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@josheleonard josheleonard force-pushed the fix--send-screen-performance-refactor branch from f3d64a7 to 6e515cf Compare September 22, 2023 15:04
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@josheleonard josheleonard force-pushed the fix--send-screen-performance-refactor branch from 6e515cf to ee683a5 Compare September 22, 2023 17:20
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@josheleonard josheleonard force-pushed the fix--send-screen-performance-refactor branch from ee683a5 to 0de752b Compare October 10, 2023 15:07
@josheleonard josheleonard added the CI/skip-ios Do not run CI builds for iOS label Oct 10, 2023
@josheleonard josheleonard force-pushed the fix--send-screen-performance-refactor branch from 81b33d4 to 14e81b4 Compare October 10, 2023 16:56
@josheleonard
chore: relocate & rename send screen components
1f047d0
@josheleonard
chore: move send screen hooks into send component
e97aacc
@josheleonard
perf: remove useAssets hook
6ccd1aa
@josheleonard
pref: remove unneeded component nesting
4d9fb77
@josheleonard
feat: add useAccountFromAddressQuery
032c37b
@josheleonard
chore: simplify send page routing hash logic
7951722
@josheleonard
chore: refactor off-chain ENS warnings UI
8adc263
@josheleonard
feat: add address endpoints
3df3504
@josheleonard
feat: add useModal hook
146d42a
@josheleonard
fix: consolidate name service lookup queries
c1a775b
@josheleonard
fix: remove useSend hook & speedup send screen
daad241
@josheleonard
chore: add cache tags for name service lookups
fc2e6e3
@josheleonard
chore: reuse common computed variables
eaf9b48
@josheleonard
chore: add mocks and storybook
823b328
@josheleonard
fix: use resolved name service address for sending
6b989e7
@josheleonard
chore: pre-submit
b07c26b
@josheleonard
perf: pre-fetch token balances on send screen
247f8e1
@josheleonard
perf: speedup finding asset from router params
34ad005
@josheleonard
pref: speedup address validation
147746f
@josheleonard
fix: do not lowercase resolved NameService address
c588c1f
@josheleonard
fix: remove token prefetching
6e7265e 
This was failing on android CI
@josheleonard
chore: remove unneeded memo & fix broken import
6060540
@josheleonard
fix: log correct error message
fb20316
Douglashdaniel
Douglashdaniel approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@Douglashdaniel Douglashdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@josheleonard josheleonard merged commit 1554a2a into master Oct 11, 2023
15 checks passed
@josheleonard josheleonard deleted the fix--send-screen-performance-refactor branch October 11, 2023 15:06
@github-actions github-actions bot added this to the 1.61.x - Nightly milestone Oct 11, 2023
@josheleonard josheleonard changed the title Fix send screen performance refactor Fix: send screen performance refactor Oct 11, 2023
@srirambv srirambv mentioned this pull request Nov 6, 2023
Closed
@josheleonard josheleonard mentioned this pull request Feb 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Douglashdaniel Douglashdaniel Douglashdaniel approved these changes

Assignees

@josheleonard josheleonard

Labels
CI/skip-ios Do not run CI builds for iOS CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet
Projects
None yet
Milestone
1.61.x - Release
Development

Successfully merging this pull request may close these issues.

Deprecate uncached name service lookups (ENS, SNS, UD)
3 participants
@josheleonard @brave-builds @Douglashdaniel