Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Brave Shield] Don't trust external filter lists by default #34275

Open
superlex opened this issue Nov 11, 2023 · 2 comments
Open

[Brave Shield] Don't trust external filter lists by default #34275

superlex opened this issue Nov 11, 2023 · 2 comments
Assignees
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.

Comments

@superlex
Copy link

superlex commented Nov 11, 2023

Description

tusted- scriptlets in external filter lists should be ignored by default

Steps to Reproduce

  1. Add a filter list that contains example.org##+js(trusted-set-cookie, excookie, example)
  2. See that excookie cookie is set with value example

Actual result:

excookie cookie is set with value example

Expected result:

excookie cookie is not set at all

Reproduces how often: Easily reproduced

Desktop Brave version: 1.60.114

Android Device details:

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? Yes
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@superlex superlex added OS/Android Fixes related to Android browser functionality OS/Desktop labels Nov 11, 2023
@diracdeltas
Copy link
Member

@ryanbr @antonok-edm is this expected behavior

@superlex
Copy link
Author

superlex commented Nov 14, 2023

In addition,

  • trusted-click-element can redirect in another site;
  • replace-node-text can replace scripts;
  • and so on.

So I think that only internal brave/ublock0 filter lists should be considered trusted by default.

Then a user could/should be able to trust other filter lists with advanced settings, e.g. via brave://adblock or brave://flags.

@diracdeltas diracdeltas added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
None yet
Development

No branches or pull requests

3 participants