Unrevert unified adblock catalog

[antonok-edm]

Revert of #20442

(This reverts commit 4ad53ad, reversing changes made to ec922be.)

Unblocks brave/brave-browser#34275

Resolves brave/brave-browser#33621

Submitter Checklist:

• I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally:
  • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
  • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

Use the test plan from #19946 (comment)

[SergeyZhukovsky]

android tests ++

[rillian]

rust++

We don't usually bump the copyright date for existing license headers, and one looks like it might be the result of a broken merge?

[antonok-edm]

this is technically a "new" file, although according to GitHub it's similar enough to the previous one that it's renamed instead. I'll keep the older copyright here too.

[cuba]

Tested in iOS and everything is fine there. Code-wise too everything looks good to me.

[github-actions]

[puLL-Merge] - brave/brave-core@21556

Description

This PR removes the ad_block_regional_service_manager, renaming it to ad_block_component_service_manager to better reflect the fact that it is now managing all adblock lists served via CRX components, not just regional ones. It also refactors several related classes and tests, incorporating updates to improve handling of the adblock filter lists.

The motivation for this change seems to be to provide a more accurate and encompassing name according to the code now that the manager isn't solely responsible for regional adblock filters.

Changes

Changes

android/android_browser_tests.gni

• Removed an entry related to test_filters_provider.cc from android_test_exception_sources, and added a dependency on test_support.

browser/brave_browser_process_impl.cc

• Removed the inclusion of ad_block_regional_service_manager.h.

browser/brave_shields

• Various changes across several test files replacing InstallDefaultAdBlockExtension with the new InstallDefaultAdBlockComponent.
• Corrected a path and service name in domain_block_page_browsertest.cc.
• Adapted tests in debounce_browsertest.cc to the new service manager.
• Changes in ephemeral_storage_1p_domain_block_browsertest.cc to move towards engine_test_observer.
• Updated includes in adblock_filter_list_catalog_entry.h for iOS, reflecting new properties (hidden, defaultEnabled, firstPartyProtections, permissionMask) and updated entries in adblock_filter_list_catalog_entry.mm.

Rust source files under components/brave_shields/adblock/rs

• Introduced new file filter_set.rs and modifications within engine.rs for new adblock features.
• Adjustments to error handling and conversions in lib.rs and result.rs.

components/brave_shields/browser directory

• Renamed ad_block_regional_service_manager to ad_block_component_service_manager.
• Created engine_test_observer for testing adblock engine updates.
• Refactored test_filters_provider to include permissions and default flags.
• Changes in ad_block_service, including commenting and removal of related adblock component IDs and public keys which seems to be relocated elsewhere.

Other Files

• Removal of test data file redirect-rule.dat.

Security Hotspots

No specific security vulnerabilities were identified in the provided diff. It appears to be a refactor and renaming intended to improve code readability and maintainability.

[iefremov]

browser/net/* lgtm