Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions are listed in Following in Brave news feed #35051

Closed
MadhaviSeelam opened this issue Dec 28, 2023 · 4 comments
Closed

Suggestions are listed in Following in Brave news feed #35051

MadhaviSeelam opened this issue Dec 28, 2023 · 4 comments

Comments

@MadhaviSeelam
Copy link

Description

Found while testing #34593. As per the testplan, Following in My feed should not list suggestions but both For You and Following listed same Suggestions.

Steps to Reproduce

  1. Install 1.62.121
  2. launch Brave
  3. enable news
  4. Add few channels (i.e. Crypto, Culture, Fashion) along with publishers (CNN, The New York Times) via Brave news dialogue
  5. close Brave and relaunch

Actual result:

image

Expected result:

Suggestions should not be listed

Reproduces how often:

Easily

Brave version (brave://version info)

Brave | 1.62.122 Chromium: 120.0.6099.144 (Official Build) beta (64-bit)
-- | --
Revision | cfddebe77d394064c472fda64afcd9fbed34ceb4
OS | Windows 11 Version 22H2 (Build 22621.2861)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@fallaciousreasoning @LorenzoMinto @rebron
cc: @stephendonner

@fallaciousreasoning
Copy link

cc @LorenzoMinto can't remember if we changed our mind on this - should suggestions show up in the following feed, for just the For You feed?

@LorenzoMinto
Copy link
Member

It should be fine if suggestions show on both feeds. Suggestion cards are meant to increase discoverability of publishers and improve the customisability experience, so the more we show them the better.

@MadhaviSeelam
Copy link
Author

Closing the issue as per the above comment from @LorenzoMinto

@fallaciousreasoning
Copy link

fallaciousreasoning commented Jan 3, 2024

Thanks for bringing this up @MadhaviSeelam! Sorry, just reread the test steps and they're pretty poorly written. By "Suggestions we think you might like" I actually meant articles from sources you aren't following not "Publisher suggestions". Really ambiguous sorry - I'll reword it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants