-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Brave News feed v2 - flip feedV2 flag by default #34593
Comments
@LaurenWags @rebron going to label this one as |
The above requires |
thanks @kjozwiak - going to mark this one |
@kjozwiak @LaurenWags sorry about the delay with the test plan - I've updated the issue to include some test steps. Please let me know if you need any more detail. |
Verification
|
example | example | example | example | example |
---|---|---|---|---|
(Compared with current 1.61.x
release and noted differences here: https://bravesoftware.slack.com/archives/C0695D60SK1/p1702935883815959.)
Opt-in experience, feed card - PASSED
Steps:
- installed
1.62.112
- launched Brave
- skipped onboarding
- scrolled down
- clicked on
Turn on Brave News
- clicked on
Refresh
Confirmed en-US
articles/sources
example | example | example |
---|---|---|
Opt-in experience, Customize
dialog - PASSED
Steps:
- installed
1.62.112
- launched Brave
- skipped onboarding
- clicked on
Customize
- clicked on
Brave News
- clicked on
Turn on Brave News
- closed the
Customize
dialog - clicked on
Refresh
Confirmed en-US
articles/sources
example | example | example | example | example | example |
---|---|---|---|---|---|
Peeking card - opted out - PASSED
- Originally logged Peeking card missing on new-tab page when opted-out of Brave News #35001 - verified ✅
Verified using
Brave | 1.62.128 Chromium: 120.0.6099.144 (Official Build) beta (x86_64)
-- | --
Revision | 41f5844c06c7db1017f39b5b6dc9ba81a6b1b9d6
OS | macOS Version 14.3 (Build 23D5033f)
peeking card | opt-in dialog |
---|---|
Peeking card - opted in - PASSED
Steps:
- installed
1.62.112
- launched Brave
- opened a new-tab page
- scrolled down
- clicked on
Turn on Brave News
- clicked on
Refresh
(to populate feed:Top Sources
feeds are not populated/shown by default on a new-profile #34958) - noted the "hero" article at the top
- scrolled up
- confirmed "peeking card" was the same story
- clicked on the story
Confirmed the feed-view opened, with that article at the top
example | example | example |
---|---|---|
Customize
dialog - PASSED
Open articles in new tab
Steps:
- installed
1.62.112
- launched Brave
- opted-in to Brave News
- clicked on the
Customize
dialog - added some sources
- left default of
Open articles in new tab
- closed the
Customize
dialog - clicked on a link in the feed
Confirmed it opened the article in a new tab
example | example |
---|---|
Open articles in current tab
Steps:
- installed
1.62.112
- launched Brave
- opted-in to Brave News
- clicked on the
Customize
dialog - added some sources
- changed
Open articles in New tab
toOpen articles in Current tab
- closed the
Customize
dialog - clicked on a link in the feed
Confirmed it opened the article in the same tab
example | example |
---|---|
Toggle Brave News
On
/Off
Brave News toggled Off |
Brave News toggled On |
---|---|
Refresh/reload - PASSED
Open, encountered issues:
- Brave News doesn't recover from lack of wifi until browser restart #35154
- no error message in Brave News when wifi is off #35153
- loading spinner for Brave News shows square outline sometimes #35155
Empty content - no sources - PASSED
Verified using
Brave | 1.62.128 Chromium: 120.0.6099.144 (Official Build) beta (x86_64)
-- | --
Revision | 41f5844c06c7db1017f39b5b6dc9ba81a6b1b9d6
OS | macOS Version 14.3 (Build 23D5033f)
- Previously logged:
- For parity, need a "no content" error dialog when user has removed all feed sources #34975 - verified ✅
Empty content - all caught up - PASSED
Feed behavior - PASSED
Lazy loading - PASSED
Steps:
- installed
1.62.129
- launched Brave
- opened a new-tab page
- scrolled down
- opted-in to
Brave News
- scrolled down
- noted new articles loaded dynamically
- kept scrolling
Confirmed scrolling loaded new article dynamically
example | example | example | example |
---|---|---|---|
Feed views (sidebar filter) - PASSED
My feed - PASSED
Steps:
- installed
1.62.112
- launched Brave
- opened a new-tab page
- scrolled down
- clicked on
Turn on Brave News
- clicked on
Customize
- added
Fox News
,CBS News
,CNN
,BBC World News
, andNBC News
- closed the dialog
- clicked on
For You
underMy Feed
- scrolled
Confirmed I saw both subscribed publisher sources as well as suggested source The Guardian World News
and others
Customize dialog |
example | example |
---|---|---|
Following - PASSED
Steps:
- installed
1.62.112
- launched Brave
- opened a new-tab page
- scrolled down
- clicked on
Turn on Brave News
- clicked on
Customize
- added
Fox News
,CBS News
,CNN
,BBC World News
, andNBC News
- closed the dialog
- clicked on
Following
underMy Feed
- scrolled
Confirmed the Following
view only shows publisher feeds I'm subscribed to
Customize dialog |
example |
---|---|
Channel Feeds - PASSED
Steps:
- installed
1.62.112
- launched Brave
- opened a new-tab page
- scrolled down
- clicked on
Turn on Brave News
- subscribed to
Brave
,Crypto
,Film and TV
, andTech News
channels - closed the
Customize
dialog - clicked on each of the channels in the
My Feed
sidebar
Confirmed the view changed to view only specific channels
Customize dialog |
Brave |
Crypto |
Film and TV |
Tech News |
---|---|---|---|---|
Publisher Feeds - PASSED
Steps:
- installed
1.62.112
- launched Brave
- opened a new-tab page
- scrolled down
- clicked on
Turn on Brave News
- clicked on
Customize
- added
Fox News
,CNN
,NBC News
,BBC World News
,CBS News
- closed the
Customize
dialog - scrolled the news feed
- clicked on each of the publishers listed in the left-hand sidebar
Confirmed I saw feed articles from each publisher, filtered
Customize dialog |
Fox News |
CNN |
NBC News |
BBC World News |
CBS News |
---|---|---|---|---|---|
Feed structure (cards, ads) - PASSED
Hero cards - PASSED
Steps:
- installed
1.62.114
- launched Brave
- opened a new-tab page
- scrolled down
- clicked on
Turn on Brave News
- clicked on
Refresh
Confirmed the "hero"
image and its article card loaded
Article cards (the normal-size cards) - PASSED
Topic cards (should have a number of recent headlines relating to an event in the news) - PASSED
Steps:
- installed
1.62.114
- launched Brave
- opened a new-tab page
- scrolled down
- clicked on
Turn on Brave News
- clicked
Refresh
Confirmed topic of US announces naval coalition to defend Red Sea shipping from Houthi attacks
, with individual news-article cards
Channel cards (should contain a few articles from the same channel) - PASSED
Steps:
- installed
1.62.114
- launched Brave
- opened a new-tab page
- scrolled down
- clicked on
Turn on Brave News
- clicked
Refresh
Confirmed I saw four (4) vertically-stacked Top Sources
cards
Discover cards (should contain 3 publisher suggestions) - PASSED
Steps:
- installed
1.62.114
- launched Brave
- opened a new-tab page
- scrolled down
- clicked on
Turn on Brave News
- clicked
Customize
- subscribed to
Fox News
andCNN
- scrolled down the feed a bit
- clicked on
Follow
forNBC News
andThe Independent World News
Confirmed You might also like
recommendations of NBC News
, Breitbart
, and The Independent World News
Confirmed article cards appeared for NBC News
and The Independent World News
You might also like |
Followed |
NBC News , The Independent World News |
---|---|---|
Profile upgrade - PASSED
Steps:
- installed
1.61.104 Chromium: 120.0.6099.115
- launched Brave
- opened a new-tab page
- scrolled down
- clicked on
Turn on Brave News
- clicked on
Customize
- added
13
total sources - shut down Brave
- renamed
Brave-Browser
profile folder toBrave-Browser-Beta
- installed and launched
1.62.112
- compared list of sources to
1.61.104
Confirmed the same 13
sources were migrated
1.61.104 |
1.62.112 |
---|---|
1.61.104 |
1.62.112 |
---|---|
Accessibility - PENDING
Encountered:
Top Sources
feeds are not populated/shown by default on a new-profile #34958- For parity, need a "no content" error dialog when user has removed all feed sources #34975
- After hiding a publisher via 3 dot menu, no feed loaded when refreshed #34973
- Need to click
Reload
on a just-added direct feed to populate it #35000 - Peeking card missing on new-tab page when opted-out of Brave News #35001
- After hiding a publisher via 3 dot menu, no feed loaded when refreshed #34973
- Suggestions are listed in
Following
in Brave news feed #35051 - Brave news doesn't refresh after unfollowing
Top sources
#35052 - Scroll position is not restored in the feed after navigating back if an article opened in the current tab #35059
- Ads should be opened in a new tab as a default along with Brave news articles #35070
- Channels are not populated in Brave News dialog after enabling news #35071
- Just-added direct feeds need explicit
Reload
/Refresh
to populate their content #35096 - Need tooltip for
X
close-window icon/button inBrave News
customize dialog #35114 - Need a tooltip for the
Brave News
on/off (enabled/disabled) toggle button #35116 - Entering
/.
in type-down autocomplete search widget yieldsGet feeds from https:///
(note the 3 forward slashes) #35142 - Not much vertical padding/whitespace between widget control and inside border of
Customize
dialog #35143 - Brave News doesn't recover from lack of wifi until browser restart #35154
- loading spinner for Brave News shows square outline sometimes #35155
- no error message in Brave News when wifi is off #35153
- Probably shouldn't have collapse/expand widget ("twisty") for unpopulated
Channels
andPublishers
views #35157
Verification
and
Feed V2 in different locales - "pt_BR" -
|
example | example | example | example | example | example |
---|---|---|---|---|---|
Note: some of the newer strings may not have translated and may be same as 1.61.x
New content available, Reload, Current tab, Publishers, My feed & For You, Ad title
customize dialog shows Principais fontes for Top Sources but the feed is not translated and shows Top sources
Brave News opt - In - PASSED
Brave News Enabled via Turn on News
card (Light theme) - PASSED
- Installed 1.62.112
- launched Brave
- clicked
Set Brave as default browser
>>Skip >>Finish - scrolled down on new tab page
- clicked
Turn on Brave News
- verified
This feed is empty
message shown - clicked
Refresh
button - confirmed news feed loaded, and top article/Hero cards is shown
- scrolled up to see the News button above peeking card
- confirmed clicking on
News
, scrolls down to top article/Hero card - clicked on an article
- article opened in a new tab as default
step 5 | step 7 | step 8 | step 9 | step 10 | step 12 |
---|---|---|---|---|---|
Brave News Enabled via Customize
Dashboard (Dark Theme) - PASSED
- New profile
- launched Brave
- clicked `Customize button
- clicked
Brave News
- clicked
Turn on Brave News
- closed
Customize
dialog - scrolled down >> clicked
Refresh
- confirmed news feed loaded with top article/Hero cards is shown
- scrolled up to see the News button above peeking card
- confirmed clicking on
News
, scrolls down to show top article/Hero card - clicked on an article
- article opened in a new tab as default
step 3 | step 4 | step 5 | step 6 | step 7 | step 8 | step 9 | step 10 | step 12 |
---|---|---|---|---|---|---|---|---|
Brave News opt-out - FAILED
- new profile
- launched Brave
- clicked
Set Brave as default browser
>>Skip >>Finish - scrolled down on new tab page
- clicked
No Thanks
on the card - confirmed peeking card displayed -
FAILED
encountered Peeking card missing on new-tab page when opted-out of Brave News #35001
example | example |
---|---|
Customize dialog
Open news articles in a New tab
as a default - PASSED
- New profile
- launched Brave
- clicked
Customize
>>Brave News - clicked
Turn on Brave News
- confirmed open articles in
New tab
is shown as a default - followed
NPR
- closed the dialog
- clicked
News
- clicked
New content available.
Reload?` - clicked top article/Hero card for NPR in the feed
- confirmed the article opened in a new tab
example | example | example |
---|---|---|
Open news articles in Current tab
- PASSED
- New profile
- launched Brave
- clicked
Customize
>>Brave News - clicked
Turn on Brave News
- selected
Current tab
in the Brave News dialog - followed
Forbes
- closed the dialog
- clicked
News
- clicked
New content available.
Reload?` - clicked top article/Hero card for Forbes in the feed
- confirmed the article opened in the current tab
example | example | example | example
------ | ------ | ----- | ----- | ------
|||
Open news articles in Current tab - Scroll position
- FAILED
- New profile
- launched Brave
- clicked
Customize
>>Brave News - clicked
Turn on Brave News
- selected
Current tab
in the Brave News dialog - followed
BBC World News
- closed the dialog
- clicked
News
- clicked
New content available.
Reload?` - clicked top article/Hero card for
BBC World News
in the feed - confirmed the article opened in the current tab
- navigated back to the feed in the current tab and the scroll position is same
- clicked an article of
BBC News
Thousands of homes still without power after Storm Gerrit
- article opened in the current tab
- navigated back to the feed in the current tab
- confirmed scroll position is stored -
Failed
- Filed Scroll position is not restored in the feed after navigating back if an article opened in the current tab #35059 - changed the window size while viewing the article and navigated back
- confirmed the last viewed article is visible in the feed -
Failed
- Filed Scroll position is not restored in the feed after navigating back if an article opened in the current tab #35059
example | example | example | example | example | example
-------- | --------- | --------- | ------- | ------ | ------ |--------
|||||
Feed behavior
Current feed view - FAILED
- New profile
- launched Brave
- enabled news via feed card
- confirmed feed loaded with top article/Hero card shown
- clicked the top article (i.e.
2 Ways Traveling ...
) - confirmed when clicked on new tab, last feed view is shown with top article peeking with
News
button - added a publisher via
+Add
via sidebar (eg. Washington Post) - clicked
New content available. Reload?
- closed and relaunched Brave
- confirmed feed is refreshed -
Failed
? - clicked
Refresh
icon - new feed loaded
- clicked Following and feed is refreshed
- clicked
For You
and feed is not refreshed -Failed
- clicked
Top sources
in theChannel
and feed is refreshed - clicked
Washington Post
in thePublishers
and feed is refreshed
step 3 | step 4 | step 5 | step 6 | step 7 | step 8 | step 10 | step 12 | step 13 | step 15 |
---|---|---|---|---|---|---|---|---|---|
Lazy Loading - PASSED
- New profile
- launched Brave
- enabled Brave News
- followed few publishers via
customize
button - followed few channels via
Add
button in the Sidebar
Confirmed when scrolling down, more and more articles are loaded.
Confirmed articles are loaded in individual publisher feeds, though fewer articles
Confirmed when navigated to an article after scrolling down the feed a long way, it should bring you back to the same place you were at.
2023-12-27_12h38_24.mp4
Feed structure (cards & Ads) - PASSED
Shared steps:
- New profile
- launched Brave
- enabled Brave News via Customize dashboard
- followed
The New York Times
,Forbes
, andTravel
channel
Hero cards - PASSED
Article cards - PASSED
Ads - PASSED
Topic Cards - PASSED
Channel cards - PASSED
Confirmed few articles from the same,Travel
, channel (Conde Nast Traveler
, Atlas Obsura
etc..) are shown in the feed
Discover cards - PASSED
Sidebar - PASSED
Sidebar UI - PASSED
- New profile
- launched Brave
- enabled Brave News
- followed few publishers via
customize
button - followed few channels via
Add
button in the Sidebar
- Confirmed Sidebar listed all the publishers and channels that are followed
- Confirmed Scrollbar is shown when followed more than 4 sources
- Confirmed default selected view is
My Feed
- Confirmed the last selected feed should be remembered across page loads
- Confirmed Publisher & Channels sections in the sidebar should be expandable/collapsable
- Confirmed Publishers/Channels
Show all
orShow less
persisted across page loads
example | example | example | example | example | example | example |
---|---|---|---|---|---|---|
My Feed - PASSED
- New profile
- launched Brave
- enabled News
- added
Travel
channel via sidebar (clicked + Add) - added
Forbes
publisher via sidebar (clicked + Add) - clicked `New content available, Reload?
- clicked
Refresh
icon at the bottom right - followed a suggestion
Business Insider
- clicked `New content available, Reload?
Confirmed My Feed
is the default view and contain articles from followed Publishers/Channels plus a few additional suggestions (Quartz, Business Insiders etc)
example | example | example | example | example | example | example |
---|---|---|---|---|---|---|
Following - FAILED
- New profile
- launched Brave
- enabled News
- confirmed default My Feed is loaded for Brave news
- followed
Travel
channel - unfollowed
Top sources
- refreshed the feed
- separately followed 2 publishers (The New York Times & CNN)
- clicked
New content available. Reload?
Confirmed no topic cards are shown
Confirmed similar to My Feed but without the suggestions you aren't following - Failed
example | example |
---|---|
Channel Feeds - PASSED
- New profile
- launched Brave
- enabled News
- unfollowed
Top sources
and addedTravel
channel via sidebar (clicked + Add) - followed
CNN
andThe New York Times
Confirmed articles from channel (Travel
) are shown
Confirmed no topic cards are shown
Publisher Feeds - PASSED
- New profile
- launched Brave
- enabled Brave News via Customize dashboard
- followed
CNN
,The New York Times
- followed
Travel
- unfollowed
Top sources
- clicked Refresh button
Confirmed Article cards & Hero cards & Ads
are shown in the feed
Confirmed only articles from the publisher are included.
example | example |
---|---|
Brave News in Multiple Profiles - PASSED
- New install
- launch Brave
- clicked
Set Brave as default browser
- click on
Google Chrome
>>Import
- clicked
Select All
to import 2 profiles - clicked
Finish
- clicked
Turn on Brave News
in the new tab page - Confirmed Brave News feed loaded for Profile 1
- clicked on
Google Chrome Person 1
- clicked
Turn on Brave News
- Followed New York Times and Technology Channel
Confirmed Brave News enabled on multiple profiles and functionality working as expected
step 5 | step 6 | step 7 | step 8 | step 9 | step 10 | step 11 |
---|---|---|---|---|---|---|
Upgrade - PASSED
- Installed
1.61.109
- launched Brave
- enabled Brave news via new tab page
- clicked
Customize
- leave
Top Sources
- added
Forbes
,ESPN
&Techradar
fromPopular
- added
Wired
from Suggestions - added
Technology
fromChannels
- closed
Customize
dialog - closed Brave
- installed
1.62.121
- renamed the profile
Brave-Browser-Beta
- launched Brave-Beta
confirmed a peeking card shown with the top article
confirmed clicking the News button scrolls down into the feed
confirmed all 4 publishers are listed in sidebar
_confirmed Top sources
shown but Technology
channel is not shown - FAILED
_
confirmed Hero cards, Article cards, Ads, Topic cards, Top News
confirmed My feed
is default view
1.61.x | peeking card | click news button | Top News | Top sources | Ads | Hero & article cards |
---|---|---|---|---|---|---|
Verified with
Opted out from rewardsserved event
view event
click event in new tab
click event in current tab
landed event
conversion event - viewConversion event
Conversion confirmation:
conversion event - click - new tabConversion event
Conversion confirmation:
conversion event - click - current tabConversion event
Conversion confirmation:
verifiable conversion eventConversion event
Conversion confirmation:
per hour capping
per day capping
orphaned events - closing tabServed the ad:
Closed tab:
Ad was served again:
orphaned events - url navigationServed the ad:
Performed search in the adress bar of the tab
Ad was served again:
Opted in to rewardsserved event
view event
click event
landed event
Verifiable conversion event
per hour capping
per day capping
orphaned eventsAd served:
Closed the tab:
ad was served again:
|
Test Plan
News
button should scroll down into the feedCustomize
button when viewing the feed should open theCustomize
dialogRefresh
button should refresh the current feedWhat the feed should contain
Lazy Loading
When scrolling down, more and more articles should be loaded. In individual publisher feeds, there are often only a few articles (10 - 20), so the easiest place to test this is the
For You
feed.If you navigate to an article after scrolling down the feed a long way, it should bring you back to the same place you were at.
Sidebar
The sidebar should contain all the publishers and channels you're following. The default selected view should be
My Feed
. The last selected feed should be remembered across page loads.My Feed
The default view. Should contain articles from Publishers/Channels you follow plus a few additional suggestions we think you might like.
Following
Similar to
My Feed
but without "Discover" articles (articles from sources/channels you aren't following). Shouldn't include topic cards.Channel Feeds
Similar to the default, but only articles from the channel should be picked (and there shouldn't be topic/channel cards).
Publisher Feeds
Should contain hero cards, article cards and advertisements. Only articles from the publisher should be included.
The text was updated successfully, but these errors were encountered: