Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Brave News]: Flip FeedV2 flag by default #21144

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Conversation

fallaciousreasoning
Copy link
Contributor

Resolves brave/brave-browser#34593

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@fallaciousreasoning
Copy link
Contributor Author

fallaciousreasoning commented Dec 8, 2023

Bypassing the puLL-Merge step (everything else is passing)

@fallaciousreasoning fallaciousreasoning merged commit 10b2d30 into master Dec 8, 2023
19 checks passed
@github-actions github-actions bot added this to the 1.63.x - Nightly milestone Dec 8, 2023
@kjozwiak
Copy link
Member

kjozwiak commented Dec 9, 2023

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.63.28 Chromium: 120.0.6099.71 (Official Build) nightly (64-bit)
-- | --
Revision | 6cb558e86b26e5e515587d1f0401a517b7b8134b
OS | Windows 11 Version 22H2 (Build 22621.2792)

Basically ensured that the Brave News Feed v2 has been enabled as per the following:

image

kjozwiak pushed a commit that referenced this pull request Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Brave News feed v2 - flip feedV2 flag by default
3 participants