Ads should be opened in a new tab as a default along with Brave news articles

[MadhaviSeelam]

Description

Found while testing #34593. As a default, Brave news articles and Ads should be opened in a new tab. Currently, when articles are clicked, they are opened in a new tab but Inline Ads are opened in the same tab.

Steps to Reproduce

1. Install 1.62.123
2. launch Brave
3. click Customize button
4. click Brave News
5. click Turn on Brave News
6. navigate to inline ad in the feed
7. click the ad

Actual result:

Ad opened in the same tab though the default is to open a new tab

Example	Example

Expected result:

Ads should open in new tab along with the news articles.

Reproduces how often:

Easily

Brave version (brave://version info)

Brave | 1.62.124 Chromium: 120.0.6099.144 (Official Build) beta (64-bit)
-- | --
Revision | d281285150cedd393f665d2b99e12cb0e62ae12a
OS | Windows 11 Version 22H2 (Build 22621.2861)

Version/Channel Information:

• Can you reproduce this issue with the current release? N/A
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@fallaciousreasoning @LorenzoMinto
cc: @stephendonner @rebron

[kjozwiak]

The above requires 1.62.131 or higher for 1.62.x verification 👍

[stephendonner]

Verification PASSED using

Brave | 1.62.131 Chromium: 120.0.6099.199 (Official Build) beta (x86_64)
-- | --
Revision | 217e8080b48df17845efb3c1a80433a8028978de
OS | macOS Version 11.7.10 (Build 20G1427)

Open articles in new tab - PASSED

Steps:

1. installed 1.62.131
2. launched Brave
3. opened a new-tab window
4. scrolled down
5. clicked on Turn on Brave News
6. clicked on Customize
7. confirmed default of Open articles in New tab
8. clicked on Unfollow next to Top Sources
9. clicked on Follow next to the Business channel
10. exited the dialog
11. clicked on Business
12. scrolled to an Ad
13. clicked on the Ad

Confirmed the Ad opened in a new tab

example	example	example	example	example	new-tab window

Open articles in current tab - PASSED

Steps:

1. installed 1.62.131
2. launched Brave
3. opened a new-tab window
4. scrolled down
5. clicked on Turn on Brave News
6. clicked on Customize
7. changed to Open articles in Current tab from default of Open articles in New tab
8. clicked on Unfollow next to Top Sources
9. clicked on Follow next to the Business channel
10. exited the dialog
11. clicked on Business
12. scrolled to an Ad
13. clicked on the Ad

Confirmed the Ad opened in the current tab

example	example	example	example	note: history entry

[stephendonner]

Gonna QA/Test-All-Platforms this one, because more eyeballs == better

[MadhaviSeelam]

Verification PASSED using

Brave | 1.62.131 Chromium: 120.0.6099.199 (Official Build) beta (64-bit)
-- | --
Revision | 217e8080b48df17845efb3c1a80433a8028978de
OS | Windows 11 Version 22H2 (Build 22621.2861)

Verified using STR from the description.

Confirmed Ad opened in new tab as a default.

Brave news dialog	Brave news feed Ad	Ad opened in a new tab	News article opened in a new tab

Confirmed Ad opened in current tab

Brave news dialog	Brave news feed Ad	Ad opened in a current tab	News feed	News article opened in current tab

[btlechowski]

Verified with

Brave	1.62.135 Chromium: 120.0.6099.199 (Official Build) beta (64-bit)
Revision	c66fd7306403245e6c370da9f287f69a5cf46a10
OS	Linux

Open articles in new tab - PASSED

Verified opening articles in new tab is selected

Confirmed the Ad opened in a new tab

Verified click confirmation was successfully redeemed

[9983:9983:0110/134151.935469:VERBOSE1:redeem_non_reward_confirmation.cc(106)] Successfully redeemed non-reward click confirmation for inline_content_ad with transaction id f5d156d0-2d3f-4c00-85cd-25a04a8044ab and creative instance id 22110568-4125-4b84-b97a-27ef45c5c07c

Verified landed confirmation was successfully redeemed

[9983:9983:0110/134157.072168:VERBOSE1:redeem_non_reward_confirmation.cc(106)] Successfully redeemed non-reward landed confirmation for inline_content_ad with transaction id d3596d2b-da3e-4431-8675-8b071d174f57 and creative instance id 22110568-4125-4b84-b97a-27ef45c5c07c

Clicking again on the same ad does not sent the confirmation:

[9983:9983:0110/134325.150605:VERBOSE1:inline_content_ad_event_handler.cc(118)] Inline content ad: Not allowed as debounced kClicked event for placement id 6fa96b5d-ce1c-4846-ba6e-b26888cc3a91
[9983:9983:0110/134325.151120:VERBOSE1:inline_content_ad_event_handler.cc(163)] Failed to fire inline content ad kClicked event for placement id 6fa96b5d-ce1c-4846-ba6e-b26888cc3a91 and creative instance id 22110568-4125-4b84-b97a-27ef45c5c07c

Open articles in current tab - PASSED

Verified opening articles in current tab is selected

Confirmed the Ad opened in the current tab

Verified click confirmation was successfully redeemed

[9983:9983:0110/134915.491006:VERBOSE1:redeem_non_reward_confirmation.cc(106)] Successfully redeemed non-reward click confirmation for inline_content_ad with transaction id 2538d722-61c9-4090-966f-692de6d196d5 and creative instance id 211a9ff9-48bf-4b79-bd2a-f6b450edac0a

Verified landed confirmation was successfully redeemed

[9983:9983:0110/134927.238993:VERBOSE1:redeem_non_reward_confirmation.cc(106)] Successfully redeemed non-reward landed confirmation for inline_content_ad with transaction id f3131560-387d-43c6-ab6c-d37753410b96 and creative instance id 211a9ff9-48bf-4b79-bd2a-f6b450edac0a

[stephendonner]

Thanks for adding the Ad-logging and verification, @btlechowski <3