-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ads should be opened in a new tab as a default along with Brave news articles #35070
Comments
The above requires |
Gonna |
Verification
Verified using STR from the description. Confirmed Ad opened in new tab as a default.
Confirmed Ad opened in current tab
|
Verified with
Open articles in new tab -
|
Verified click confirmation was successfully redeemed
[9983:9983:0110/134915.491006:VERBOSE1:redeem_non_reward_confirmation.cc(106)] Successfully redeemed non-reward click confirmation for inline_content_ad with transaction id 2538d722-61c9-4090-966f-692de6d196d5 and creative instance id 211a9ff9-48bf-4b79-bd2a-f6b450edac0a
Verified landed confirmation was successfully redeemed
[9983:9983:0110/134927.238993:VERBOSE1:redeem_non_reward_confirmation.cc(106)] Successfully redeemed non-reward landed confirmation for inline_content_ad with transaction id f3131560-387d-43c6-ab6c-d37753410b96 and creative instance id 211a9ff9-48bf-4b79-bd2a-f6b450edac0a
Thanks for adding the |
Description
Found while testing #34593. As a default, Brave news articles and Ads should be opened in a new tab. Currently, when articles are clicked, they are opened in a new tab but Inline Ads are opened in the same tab.
Steps to Reproduce
Customize
buttonBrave News
Turn on Brave News
Actual result:
Ad opened in the same tab though the default is to open a new tab
Expected result:
Ads should open in new tab along with the news articles.
Reproduces how often:
Easily
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
@fallaciousreasoning @LorenzoMinto
cc: @stephendonner @rebron
The text was updated successfully, but these errors were encountered: