Brave News doesn't recover from lack of wifi until browser restart

[LaurenWags]

Description

When there isn't wifi, you will encounter #35153 with Brave News. When wifi is restored, I'd expect Brave News to load (either after refreshing current tab or opening a new one), however the loading spinner persists. I've only been able to get news to work with a browser restart. This occurs with both v1 and v2.

Steps to Reproduce

1. Have a profile with news enabled (but not launched)
2. Turn off wifi for your device
3. Launch the profile
4. Open a new tab and try to access news (encounter no error message in Brave News when wifi is off #35153)
5. Restore wifi for device
6. Refresh tab/open new tab, neither will make Brave News load - spinner is just shown continuously
7. Try restarting the browser then opening new tab, now Brave News will load

Actual result:

Brave News continues to show loading spinner even though internet access is restored, seems like it can't recover from state without internet access

Expected result:

Brave News should be able to recover

Reproduces how often:

easily

Brave version (brave://version info)

1.61.x, 1.62.x

Version/Channel Information:

• Can you reproduce this issue with the current release? yes
• Can you reproduce this issue with the beta channel? yes
• Can you reproduce this issue with the nightly channel?

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @brave/qa-team @fallaciousreasoning

[stephendonner]

We neither timeout from the initial request (#35153), nor recover once reconnected to Wi-Fi:

[kjozwiak]

The above requires 1.62.138 or higher for 1.62.x verification 👍

[btlechowski]

Verified with

Brave	1.62.144 Chromium: 120.0.6099.217 (Official Build) beta (64-bit)
Revision	75de8d953f6a5686e425d46d7f0dc9284dc1c064
OS	Linux

Verified test plan from the description
Verified Brave News feed loaded

Logged #35361

[MadhaviSeelam]

Verification PASSED using

Brave | 1.62.147 Chromium: 120.0.6099.234 (Official Build) (64-bit)
-- | --
Revision | 3b25c3743150a54485dea24f0ceb1e69d6db51bc
OS | Windows 11 Version 22H2 (Build 22621.3007)

1. Installed 1.62.147
2. launched Brave
3. enabled #brave-news-feed-update via brave://flags
4. enabled Brave news via Customize button
5. closed Brave
6. disconnected WiFi/Network
7. relaunched Brave
8. opened new tab and You appear to be offline error message shown as expected
9. enabled WiFi
10. clicked New Content available. Reload? button

• Confirmed New content available. Reload? message shown
• Confirmed Brave news feed loaded

step 3	step 4	step 6	step 8	step 10

[LaurenWags]

Verified with

Brave | 1.62.147 Chromium: 120.0.6099.234 (Official Build) (x86_64)
-- | --
Revision | 3b25c3743150a54485dea24f0ceb1e69d6db51bc
OS | macOS Version 13.6.3 (Build 22G436)

Scenario 1: Test plan from brave/brave-core#21507 (comment)

1. Start Brave with no internet
2. An error message for "You appear to be offline" should show up
3. Connect
4. Refresh
5. Feed should load
6. Go offline
7. Change feed (should work fine)
8. Refresh
9. Offline message should show

Step 2	Step 4	Step 5	Step 6	Step 7	Step 9

Scenario 2:

1. Installed 1.62.147
2. launched Brave
3. enabled #brave-news-feed-update via brave://flags and relaunched
4. enabled Brave news via Customize button
5. closed Brave
6. disconnected WiFi/Network
7. relaunched Brave
8. opened new tab and You appear to be offline error message shown as expected
9. enabled WiFi
10. clicked New Content available. Reload? button
11. Confirmed feed loaded as expected

• Confirmed New content available. Reload? message shown
• Confirmed Brave news feed loaded

step 3	step 4	step 6	step 8	step 10	step 11