Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loading spinner for Brave News shows square outline sometimes #35155

Closed
LaurenWags opened this issue Jan 5, 2024 · 5 comments · Fixed by brave/brave-core#21507
Closed

loading spinner for Brave News shows square outline sometimes #35155

LaurenWags opened this issue Jan 5, 2024 · 5 comments · Fixed by brave/brave-core#21507

Comments

@LaurenWags
Copy link
Member

Description

Sometimes the loading spinner for Brave News displays a square outline. Seems to depend on background color of the NTP and possibly the fade/blur as you scroll on Brave News?

Steps to Reproduce

  1. Reliably get into a situation where the loading spinner displays (ex. no error message in Brave News when wifi is off #35153)
  2. Look at the loading spinner on a variety of NTP backgrounds (and scroll positions on the page)

Actual result:

Sometimes the square outline is visible:

Example Example
Screenshot 2024-01-05 at 1 04 16 PM Screenshot 2024-01-05 at 1 15 15 PM

Expected result:

No square outline visible

Reproduces how often:

easily

Brave version (brave://version info)

1.62.x, 1.63.x

Version/Channel Information:

  • Can you reproduce this issue with the current release? no
  • Can you reproduce this issue with the beta channel? yes, 1.62.x
  • Can you reproduce this issue with the nightly channel? yes 1.63.x

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @brave/qa-team @fallaciousreasoning

@stephendonner
Copy link

Now that I see the square, I can't unsee it 😉

@AyushNigam11
Copy link

Need to conditional styling and CSS adjustments

@AyushNigam11
Copy link

Need to conditional styling and CSS adjustments

do*

@kjozwiak
Copy link
Member

The above requires 1.62.138 or higher for 1.62.x verification 👍

@stephendonner
Copy link

Verification PASSED using

Brave | 1.62.144 Chromium: 120.0.6099.217 (Official Build) beta (x86_64)
-- | --
Revision | 75de8d953f6a5686e425d46d7f0dc9284dc1c064
OS | macOS Version 11.7.10 (Build 20G1427)

Confirmed via visual inspection that the square background is no more

example example
Screen Shot 2024-01-16 at 4 27 08 PM Screen Shot 2024-01-16 at 4 34 58 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants