Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component updater should check for component updates more often (frequency set via Griffin) #35164

Closed
ShivanKaul opened this issue Jan 6, 2024 · 1 comment · Fixed by brave/brave-core#21868
Closed

Component updater should check for component updates more often (frequency set via Griffin) #35164

ShivanKaul opened this issue Jan 6, 2024 · 1 comment · Fixed by brave/brave-core#21868
Assignees
@antonok-edm
Labels
feature/shields/adblock Blocking ads & trackers with Shields OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. privacy QA/No release-notes/include
Milestone
1.68.x - Release

Comments

@ShivanKaul
Copy link
Collaborator

Similar to #32274, we need to update other components faster and on a Griffin-customizable schedule for e.g. the Easylist Cookie component. Currently only the following components' update checking can be controlled via AdBlockComponentUpdateInterval:

  • Brave Ad Block Updater
  • Brave Ad Block First Party Filters
  • Brave Ad Block Resources Library
@ShivanKaul ShivanKaul added OS/Android Fixes related to Android browser functionality OS/Desktop labels Jan 6, 2024
@antonok-edm antonok-edm self-assigned this Jan 6, 2024
@antonok-edm antonok-edm added the feature/shields/adblock Blocking ads & trackers with Shields label Jan 6, 2024
@antonok-edm
Copy link
Collaborator

This should be much simpler after #33621.

@ShivanKaul ShivanKaul added privacy priority/P2 A bad problem. We might uplift this to the next planned release. labels Jan 9, 2024
@ShivanKaul ShivanKaul mentioned this issue Feb 1, 2024
Closed
@antonok-edm antonok-edm mentioned this issue Feb 2, 2024
Merged
24 tasks
@mherrmann mherrmann mentioned this issue Apr 27, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.68.x - Nightly milestone May 14, 2024
@LaurenWags LaurenWags mentioned this issue Jul 22, 2024
Closed
@hffvld hffvld mentioned this issue Jul 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antonok-edm antonok-edm

Labels
feature/shields/adblock Blocking ads & trackers with Shields OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. privacy QA/No release-notes/include
Projects
None yet
Milestone
1.68.x - Release
Development

Successfully merging a pull request may close this issue.

Use AdBlockDefaultResourceUpdateInterval for all adblock-related components brave/brave-core
3 participants
@ShivanKaul @antonok-edm @brave-builds