Add button on brave://adblock page to force-update all adblock components

[ShivanKaul]

It would help adblock breakage remediation tremendously if users can force-update all adblock components by going to brave://adblock and pressing a button instead of having to go to brave://components and clicking each Update button manually.

The button could live under the Filter lists section:

Subsection Title: Update all filter lists
Helper Text: Manually update all filter lists to latest version
Button Text: Update lists

[stephendonner]

cc @aguscruiz

[aguscruiz]

Added the designs here:
https://www.figma.com/file/tLXWGCpNoiJxDZDdpfordj/%5BARCHIVE%5D-Desktop-Settings?type=design&node-id=4262%3A78166&mode=design&t=nZVBGxEjpmvYEC3u-1

[ShivanKaul]

iOS corollary: #35982

[zenparsing]

@ShivanKaul which components would this button update? Given the placement of the button, it seems like it would just update the components associated with enabled filtered lists. Are there any other components that would need to be updated as well?

[ShivanKaul]

enabled filtered lists

Right, so enabled filter lists (like EasyList Cookie, or whichever ones the user has selected from the list) + their associated components, as well as the following adblock related components:

Brave Ad Block List Catalog
Brave Ad Block Updater 
Brave Ad Block Resources Library

Additionally, it would be good to update any custom filter lists the user has added, but I don't think this is a showstopper.

[ShivanKaul]

Ah actually, @antonok-edm tells me that he has to write a "update all adblock lists + components" function for #35164. So might be easier for the UI to use that!

[antonok-edm]

a "update all adblock lists + components" function for #35164

@zenparsing See this upcoming AdBlockComponentServiceManager::CheckAdBlockComponentsUpdate.

it would be good to update any custom filter lists the user has added, but I don't think this is a showstopper.

+1. I'd suggest a similar implementation on AdBlockSubscriptionServiceManager. LMK if you need any help with that.

[bsclifton]

I believe @deeppandya is looking at this on Android

This should make #35166 much easier to implement! 😄

[deeppandya]

@ShivanKaul android issue for the same : #35270

[MadhaviSeelam]

Verification PASSED using

Brave | 1.67.85 Chromium: 125.0.6422.60 (Official Build) beta (64-bit)
-- | --
Revision | d01060f5ec155e6eb64a335203663a29c0e5d81f
OS | Windows 11 Version 23H2 (Build 22631.3593)

Case 1: New install Update successful - PASSED

1. Installed 1.67.85
2. launched Brave
3. opened brave://settings/shields/filters
4. In a new window, open brave://components
5. Make sure that you can see the content of both windows at the same time.
6. Press the "Update lists" button on the settings page

Confirmed Lists updated button shown as expected

Confirmed below Adblock components are updated successfully with the statuses as expected when clicked Update lists button.

• Brave Ad Block Updater - Component already up to date
• Brave Ad Block First Party Filters - Component already up to date

Confirmed default lists EasyList Cookie and Fanboy's Mobile Notifications are updated

2024-05-17_09h19_02.mp4

Confirmed user selected lists YouTube Mobile Distractions & uBlock Annoyances are updated

2024-05-16_16h51_23.mp4

Case 2: New install Updated failed - PASSED

1. Installed 1.67.85
2. launched Brave
3. opened brave://settings/shields/filters
4. In a new window, open brave://components
5. Make sure that you can see the content of both windows at the same time.
6. Disconnect internet/WiFi
7. Press the "Update lists" button on the settings page

Confirmed Updated failed - Retry button shown as expected

Confirmed Adblock components are shown Update error status as below when clicked Update lists button.

• Brave Ad Block Updater - Update error
• Brave Ad Block First Party Filters - - Update error``

2024-05-20_09h46_21.mp4

Case 3: Upgrade - PASSED

1. Installed 1.66.110
2. launched Brave
3. opened brave://settings/shields/filters
4. verified Show full list button is shown
5. opened brave://components in a new window and verified components are verified
6. closed the browser and renamed the profile brave-browser-beta
7. installed 1.67.87 relaunched Brave
8. opened both windows and can see the content of both windows at the same time.
9. confirmed Update Lists button is shown
10. Press the "Update lists" button on the settings page
11. Verify that AdBlock components are updated, as reflected on the brave://components page

Confirmed adblock components are updated as expected.

1.66.x	1.67.x

Case 4: Buttons UI (Light theme/Dark theme) - PASSED

Update Lists	Lists Updated

[MadhaviSeelam]

Adding QA/Test-All-Platforms label to verify force-update to the adblock components

[MadhaviSeelam]

Verification PASSED using

Brave	1.67.94 Chromium: 125.0.6422.112 (Official Build) beta (64-bit) 
Revision	3e4d210c91412b82ad8cffca556b12bbe40ff962
OS	Linux

Case 1: New install Update successful - PASSED

1. Installed 1.67.94
2. launched Brave
3. opened brave://settings/shields/filters
4. In a new window, open brave://components
5. Make sure that you can see the content of both windows at the same time.
6. Press the "Update lists" button on the settings page

Confirmed Lists updated button shown as expected

Confirmed below Adblock components are updated successfully with the statuses as expected when clicked Update lists button.

• Brave Ad Block Updater - Component already up to date
• Brave Ad Block First Party Filters - Component already up to date

Confirmed default lists EasyList Cookie and Fanboy's Mobile Notifications are updated

2024-05-24_13h14_36.mp4

Confirmed user selected lists YouTube Mobile Distractions & Fanboy's Annoyances are updated

2024-05-24_13h34_58.mp4

Case 2: New install Updated failed - PASSED

1. Installed 1.67.85
2. launched Brave
3. opened brave://settings/shields/filters
4. In a new window, open brave://components
5. Make sure that you can see the content of both windows at the same time.
6. Disconnect internet/WiFi
7. Press the "Update lists" button on the settings page

Confirmed Updated failed - Retry button shown as expected

Confirmed Adblock components are shown Update error status as below when clicked Update lists

button.

• Brave Ad Block Updater - Update error
• Brave Ad Block First Party Filters - Update error

2024-05-24_13h58_27.mp4

Case 3: Upgrade - PASSED

1. Installed 1.66.115
2. launched Brave
3. opened brave://settings/shields/filters
4. verified Show full list button is shown
5. opened brave://components in a new window and verified components are verified
6. closed the browser and renamed the profile brave-browser-beta
7. installed 1.67.87 relaunched Brave
8. opened both windows and can see the content of both windows at the same time.
9. confirmed Update Lists button is shown
10. Press the "Update lists" button on the settings page
11. Verify that AdBlock components are updated, as reflected on the brave://components page

Confirmed adblock components are updated as expected.

1.66.x	1.67.x (Update lists)	1.67.x (Lists updated)

Case 4: Buttons UI (Light theme) - PASSED

Update Lists	Lists Updated

[stephendonner]

Verification PASSED using

Brave | 1.67.100 Chromium: 125.0.6422.112 (Official Build) beta (x86_64)
-- | --
Revision | 34fcbb6655521b55468af6c63601a8e3c5d24cd2
OS | macOS Version 14.5 (Build 23F79)

Case 1: New install Update successful - PASSED

1. installed 1.67.100
2. launched Brave
3. opened brave://settings/shields/filters
4. in a new window, opened brave://components
5. made sure I can see the content of both windows at the same time
6. pressed the "Update lists" button on the settings page

Confirmed Lists updated button shown as expected

Confirmed below Adblock components are updated successfully with the statuses as expected when clicked Update lists button.

• Brave Ad Block Updater - Component already up to date
• Brave Ad Block First Party Filters - Component already up to date

Confirmed default lists EasyList Cookie and Fanboy's Mobile Notifications are updated

Confirmed user-selected lists Fanboy's Anti-chat Apps & YouTube Mobile Recommendations are updated

Case 2: New install Updated failed - PASSED

1. installed 1.67.100
2. launched Brave
3. opened brave://settings/shields/filters
4. In a new window, open brave://components
5. make sure that you can see the content of both windows at the same time.
6. disconnect internet/Wi-Fi
7. press the "Update lists" button on the settings page

Confirmed Updated failed - Retry button shown as expected

Confirmed Adblock components are shown Update error status as below when clicked Update lists

button.

• Brave Ad Block Updater - Update error
• Brave Ad Block First Party Filters - Update error

Case 3: Upgrade - PASSED

1. installed 1.66.115
2. launched Brave
3. opened brave://settings/shields/filters
4. verified Show full list button is shown
5. opened brave://components in a new window and verified components are verified
6. closed the browser and renamed the profile brave-browser-beta
7. installed 1.67.100
8. relaunched Brave
9. opened both windows and can see the content of both windows at the same time.
10. confirmed Update Lists button is shown
11. Press the "Update lists" button on the settings page
12. Verify that AdBlock components are updated, as reflected on the brave://components page

Confirmed adblock components are updated as expected.

1.66.x	1.67.x (Update lists)	1.67.x (Lists updated)

Case 4: Buttons UI (Dark theme) - PASSED

Update Lists	Lists Updated

[superlex]

Currently, it looks like the button update only default filter lists (included optional ones).
I think it should update all filter lists, that is filter lists added by user as well (custom filter lists).

This is important above all on Android, where there isn't an option yet to update custom filter lists.

[ShivanKaul]

Currently, it looks like the button update only default filter lists.

This should update all optional and default enabled filter lists. Is that not what you're seeing? For custom filter lists, we could add a separate "Update all" button (since it's in a separate section) but that's a more advanced use-case.

[superlex]

Thanks for your reply.
Yes, I meant what you said, and I agree with "Update all" button idea.