Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button in AdBlock settings to update AdBlock components #22881

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented Apr 2, 2024

Resolves brave/brave-browser#35216

Screen.Recording.2024-04-02.at.3.25.36.PM.mov

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Open brave://settings/shields/filters
  • In a new window, open brave://components
  • Make sure that you can see the content of both windows at the same time.
  • Press the "Update lists" button on the settings page
  • Verify that AdBlock components are updated, as reflected on the brave://components page

@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Apr 2, 2024
@zenparsing zenparsing force-pushed the ksmith-adblock-update-lists branch 2 times, most recently from 931ce39 to 6a3e15f Compare April 2, 2024 19:26
@zenparsing zenparsing marked this pull request as ready for review April 2, 2024 19:45
@zenparsing zenparsing requested review from a team as code owners April 2, 2024 19:45
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string and chromium_src LGTM

@zenparsing zenparsing merged commit 82c2844 into master Apr 12, 2024
19 checks passed
@zenparsing zenparsing deleted the ksmith-adblock-update-lists branch April 12, 2024 16:24
@github-actions github-actions bot added this to the 1.67.x - Nightly milestone Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add button on brave://adblock page to force-update all adblock components
4 participants