Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If feed is empty after unfollowing sources, incorrect message is shown in nightly #35274

Closed
MadhaviSeelam opened this issue Jan 11, 2024 · 4 comments · Fixed by brave/brave-core#21557

Comments

@MadhaviSeelam
Copy link

MadhaviSeelam commented Jan 11, 2024

Description

Found while testing #35157. After unfollowing all sources, including Top sources, and while connected to WiFi, incorrect message shown You appear to be offline with Refresh button. Correct message should be Your Feed is Empty as in 1.62.x

Steps to Reproduce

  1. Install 1.63.110
  2. launch Brave
  3. clicked Customize >>Brave News in a new tab
  4. unfollow Top Sources
  5. Return to feed
  6. verified Wifi is Connected

Actual result:

You appear to be offline message shown

Expected result:

Your Feed is Empty message should be shown as in 1.62.x

Reproduces how often:

Easily

Brave version (brave://version info)

Brave | 1.63.110 Chromium: 120.0.6099.217 (Official Build) nightly (64-bit)
-- | --
Revision | f7a7c2ee42626f5a1310c9bd6789d0438e78ca6e
OS | Windows 11 Version 22H2 (Build 22621.3007)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@fallaciousreasoning @LorenzoMinto
cc: @brave/qa-team

@stephendonner
Copy link

Thanks for logging this - I noticed it while testing brave/brave-core#21507 but didn't want to hold up those other improvements 👍

@fallaciousreasoning
Copy link

Nice catch!

@kjozwiak
Copy link
Member

The above requires 1.62.145 or higher for 1.62.x verification 👍

@stephendonner
Copy link

Verified using

Brave | 1.62.144 Chromium: 120.0.6099.217 (Official Build) beta (x86_64)
-- | --
Revision | 75de8d953f6a5686e425d46d7f0dc9284dc1c064
OS | macOS Version 11.7.10 (Build 20G1427)

Steps:

  1. installed 1.62.144
  2. launched Brave
  3. opened a new-tab page
  4. scrolled down
  5. clicked on Turn on Brave News
  6. clicked to Unfollow the Top Sources feed
  7. closed the dialog
  8. clicked on the Reload? button

Confirmed the feed was empty, and I got the appropriate Your Feed is Empty message

example example example example example
Screen Shot 2024-01-16 at 3 41 15 PM Screen Shot 2024-01-16 at 3 41 21 PM Screen Shot 2024-01-16 at 3 41 29 PM Screen Shot 2024-01-16 at 3 41 39 PM Screen Shot 2024-01-16 at 3 41 43 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment