Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Brave News]: Fix scroll restore bug & error message with no feeds (uplift to 1.62.x) #21578

Merged
merged 2 commits into from
Jan 16, 2024
Merged

[Brave News]: Fix scroll restore bug & error message with no feeds (uplift to 1.62.x) #21578

merged 2 commits into from
Jan 16, 2024

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jan 15, 2024 •
edited by kjozwiak
Loading

Uplift of #21557
Uplift of #21581
Resolves brave/brave-browser#35059
Resolves brave/brave-browser#35274

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner January 15, 2024 19:18
@brave-builds brave-builds added this to the 1.62.x - Beta milestone Jan 15, 2024
@brave-builds brave-builds self-assigned this Jan 15, 2024
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jan 15, 2024
@brave-builds
Copy link
Collaborator Author

A Storybook has been deployed to preview UI for the latest push

@fallaciousreasoning
[Brave News]: Fix feed restore bug & edit add button padding (#21581)
a465368 
* Fix feed restore bug

* Reduce button padding
@brave-builds
Copy link
Collaborator Author

A Storybook has been deployed to preview UI for the latest push

kjozwiak
kjozwiak approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.62.x approved 👍 QA has verified the above PR(s) on Nightly via 1.63.x as per #21557 (comment) & #21581 (comment).

@kjozwiak kjozwiak merged commit 26ffe8c into 1.62.x Jan 16, 2024
13 checks passed
@kjozwiak kjozwiak deleted the pr21557_bn-tweaks-6_1.62.x branch January 16, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.62.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @fallaciousreasoning