-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spotify OOM crash #40886
Comments
So the above is still happening. I was listening to some music while working and it crashed after about ~2hrs. It was running in a tab and when I switched to it to pause the music, the WebView crashed. Using the following on
Crashes:
|
We identified and upstreamed a memory hog fix to Chromium. In fact, the primary issue is in the site JS and fixing C++ hog doesn't help enough (but probably extended a lifetime a little). The real issue is ReCaptcha. Why?
|
Here is the screencast of the issue (Brave): |
https://recaptcha-demo.appspot.com/recaptcha-v3-request-scores.php also reproduces the issue. |
The feature was implemented here: brave/brave-core#15309 |
The steps to verify: Option 1.
Option 2
Expected result: <= 300 MB memory usage |
I'm going to disable the feature in the code too: brave/brave-core#25877 |
We pushed brave/brave-variations#1215 via Griffin for the time being which resolves the above issue. Both As per #40886 (comment), we'll also push this change via |
|
Description
See the following reports:
@atuchin-m suggested that this might be happening because of several requestIdleCallback trigged by reCaptcha JS on the spotify site: #36356 (comment)
Doesn't look related to Shields or Playlist from reports (disabling either doesn't help).
Steps to reproduce
Actual result
The tab complains of high memory usage, and eventually crashes.
Expected result
Tab should not crash.
Reproduces how often
Easily reproduced
Brave version (brave://version info)
All
Channel information
Reproducibility
Miscellaneous information
No response
The text was updated successfully, but these errors were encountered: