Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BraveRoundTimeStamps conflict with ReCaptcha #41472

Open
atuchin-m opened this issue Oct 8, 2024 · 2 comments
Open

Fix BraveRoundTimeStamps conflict with ReCaptcha #41472

atuchin-m opened this issue Oct 8, 2024 · 2 comments
Assignees
Labels
feature/shields The overall Shields feature in Brave.

Comments

@atuchin-m
Copy link
Contributor

BraveRoundTimeStamps results in OOMs on sites that use ReCaptcha. The details and steps to reproduce is here: #40886

The feature will be disabled soon to fix the issue. If we want to re-enable it, we should find a way to resolve the conflict.

@atuchin-m atuchin-m added the feature/shields The overall Shields feature in Brave. label Oct 8, 2024
@atuchin-m atuchin-m reopened this Oct 8, 2024
@bsclifton
Copy link
Member

bsclifton commented Oct 17, 2024

This change definitely affected YouTube too. See #29432 (comment)

@szilardszaloki had attempted a fix with brave/adblock-resources#131... and some users reported that worked. But it definitely broke again.

After the revert via variations server, multiple folks confirmed YouTube history is now working great for them

If there is a proposed fix for this in the future, we'll want to run through the test plan in #29432 to make sure it works for that case too.

@atuchin-m
Copy link
Contributor Author

atuchin-m commented Oct 17, 2024

Sounds great, @bsclifton, thanks for the details!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields The overall Shields feature in Brave.
Projects
None yet
Development

No branches or pull requests

3 participants