Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use uploadComponent.js for upload-ipfs-component #144

Merged
merged 1 commit into from
Jun 26, 2020

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Jun 26, 2020

Fix #137

cc @bbondy

@yrliou yrliou self-assigned this Jun 26, 2020
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would be good to make sure the README includes this info too

@yrliou
Copy link
Member Author

yrliou commented Jun 26, 2020

The document is a bit out of date and ipfs has not been documented at all yet, talked with @emerick, we'll create a follow up issue for document. Merging.

@yrliou yrliou merged commit 54e6272 into master Jun 26, 2020
@yrliou yrliou deleted the refactor_ipfs_upload branch June 26, 2020 21:08
@yrliou
Copy link
Member Author

yrliou commented Jun 26, 2020

Documentation issue created: #145.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPFS and Tor update scripts have duplicated code
3 participants