filter out unsupported regex hostnames in cosmetic filters #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonok-edm
force-pushed
the
unsupported-cosmetic-regex-hostname
branch
from
a5a5b92 to
3191d46
Compare
ShivanKaul
approved these changes
Sep 21, 2024
ShivanKaul
reviewed
Sep 21, 2024
| // Brave throws an error from the generic filter injection script if any CSS is invalid. | ||
| // https://github.com/uBlockOrigin/uAssets/commit/6eaa9dd46371478d76371426cb99f75d99c7402d | ||
| if (line.startsWith('##') >= 0 && line.indexOf('head\\"') >= 0) { | ||
| if (line.startsWith('/^dizipal\\d+\\.com$/##')) { |
There was a problem hiding this comment.
This regex makes me nervous, do we have unit tests for this?
There was a problem hiding this comment.
It's a string, not a regex 😛
There was a problem hiding this comment.
Ah the filter rule has a regex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve the following error for now:
I'll investigate the root cause later and make sure adblock-rust is prepared to handle these properly.