Skip to content

Commit

Permalink
fix(privacy): Shred intermittently not clearing all data (uplift to 1…
Browse files Browse the repository at this point in the history
….72.x) (#26278)

Uplift of #26246 (squashed) to beta
  • Loading branch information
brave-builds authored Oct 30, 2024
1 parent 14b8282 commit 3f04f64
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions ios/brave-ios/Sources/Brave/Frontend/Browser/TabManager.swift
Original file line number Diff line number Diff line change
Expand Up @@ -843,6 +843,10 @@ class TabManager: NSObject {
// Remove all unwanted tabs
for tab in allTabs {
guard tab.url?.baseDomain == etldP1 else { continue }
// The Tab's WebView is not deinitialized immediately, so it's possible the
// WebView still stores data after we shred but before the WebView is deinitialized.
// Delete the web view to prevent data being stored after data is Shred.
tab.deleteWebView()
removeTab(tab)
}

Expand Down

0 comments on commit 3f04f64

Please sign in to comment.