[ads] Add SmartNTT operating system condition matcher

brave · Oct 29, 2024 · b6fc1b8 · b6fc1b8
1 parent db7611b
commit b6fc1b8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/browser/brave_ads/ads_service_delegate.cc b/browser/brave_ads/ads_service_delegate.cc
@@ -154,6 +154,7 @@ base::Value::Dict AdsServiceDelegate::GetVirtualPrefs() {
   }
 
   return base::Value::Dict()
+      .Set("[virtual]:operating_system.name", version_info::GetOSType())
       .Set("[virtual]:build_channel.name",
            version_info::GetChannelString(chrome::GetChannel()))
       .Set("[virtual]:browser_version", version_info::GetVersionNumber())

diff --git a/components/brave_ads/core/public/serving/new_tab_page_ad_serving_condition_matcher_util.h b/components/brave_ads/core/public/serving/new_tab_page_ad_serving_condition_matcher_util.h
@@ -111,6 +111,10 @@ class PrefProviderInterface;
 // profile or local state preferences. Virtual preference path keys should be
 // prefixed with "[virtual]:".
 //
+// "[virtual]:operating_system.name" retrieves the operating system, returning
+// one of the following values: "Windows", "Mac OS X", "Linux", "Android",
+// "iOS", or "Unknown".
+//
 // "[virtual]:build_channel.name" retrieves the build channel of the browser,
 // returning one of the following values: "stable", "beta", "dev", "nightly", or
 // "unknown".