Skip to content

Commit

Permalink
[CodeHealth] Disallow new NOTREACHED_IN_MIGRATION instances
Browse files Browse the repository at this point in the history
This PR adds a new presubmit check to prevent the introduction of new
occurrences for `NOTREACHED_IN_MIGRATION`. This macro is supposed to be
on its way out, however there are still new occurrances being introduced
in recent times.
  • Loading branch information
cdesouza-chromium committed Oct 30, 2024
1 parent f98f048 commit f8a04d2
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions PRESUBMIT.py
Original file line number Diff line number Diff line change
Expand Up @@ -359,6 +359,15 @@ def CheckNewSourceFileWithoutGnChangeOnUpload(input_api, output_api):
treat_as_error=True,
excluded_paths=[_THIRD_PARTY_EXCEPT_BLINK],
),
BanRule(
'NOTREACHED_IN_MIGRATION',
('Do not introduce new cases of of NOTREACHED_IN_MIGRATION. Please ',
'refer to the guide for how to use CHECK/DCHECK/NOTREACHED ',
'https://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/checks.md.'
),
treat_as_error=True,
excluded_paths=[],
),
)


Expand Down

0 comments on commit f8a04d2

Please sign in to comment.