Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't merge - this is a CI run for https://github.com/brave/brave-core/pull/19785 #20081

Merged
merged 12 commits into from
Sep 19, 2023

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Sep 10, 2023

syncing #19785

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@github-actions github-actions bot added the potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false label Sep 10, 2023
@sangwoo108 sangwoo108 self-assigned this Sep 11, 2023
@github-actions github-actions bot force-pushed the contributor-thirumurugan-git-vtab-drag-n-drop branch from 0e9fb35 to 27dc3ca Compare September 11, 2023 00:40
@github-actions github-actions bot force-pushed the contributor-thirumurugan-git-vtab-drag-n-drop branch from b7df2fa to 79cae2c Compare September 18, 2023 13:10
@sangwoo108 sangwoo108 merged commit cc69cb1 into master Sep 19, 2023
15 checks passed
@sangwoo108 sangwoo108 deleted the contributor-thirumurugan-git-vtab-drag-n-drop branch September 19, 2023 07:32
@github-actions github-actions bot added this to the 1.60.x - Nightly milestone Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants