Use geo country returned from Rewards connect endpoints #20151

zenparsing · 2023-09-13T18:18:29Z

Submitter Checklist:

I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
There is a ticket for my issue
Used Github auto-closing keywords in the PR description above
Wrote a good PR/commit description
Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
Checked the PR locally:
- npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
- npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
Ran git rebase master (if needed)

Reviewer Checklist:

A security review is not needed, or a link to one is included in the PR description
New files have MPL-2.0 license header
Adequate test coverage exists to prevent regressions
Major classes, functions and non-trivial code blocks are well-commented
Changes in component dependencies are properly reflected in gn
Code follows the style guide
Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Instead of overriding CreateOriginLabel just for Password Manager override FormatOriginForSecurityDisplay for global replacement of chrome:// for brave://.

github-actions · 2023-09-13T18:24:03Z

components/brave_rewards/core/wallet_provider/bitflyer/connect_bitflyer_wallet.cc

-      &ConnectBitFlyerWallet::OnConnect, base::Unretained(this),
-      std::move(callback), std::move(token), std::move(address), std::string());
+  auto on_connect =
+      base::BindOnce(&ConnectBitFlyerWallet::OnConnect, base::Unretained(this),


_{reported by reviewdog 🐶}
[semgrep] base::Unretained is most of the time unrequited, and a weak reference is better suited for secure coding.
Consider swapping Unretained for a weak reference.
base::Unretained usage may be acceptable when a callback owner is guaranteed
to be destroyed with the object base::Unretained is pointing to, for example:

- PrefChangeRegistrar
- base::*Timer
- mojo::Receiver
- any other class member destroyed when the class is deallocated

Source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/c/chromium-uaf.yaml

Cc @thypon @goodov @iefremov

components/brave_rewards/core/wallet_provider/zebpay/connect_zebpay_wallet.cc

components/brave_rewards/core/endpoints/common/post_connect.cc

components/brave_rewards/core/wallet_provider/connect_external_wallet.cc

Use wallet provider name on send contribution button

…urityDisplay Override FormatOriginForSecurityDisplay.

Update adblock-rust to v0.8.1

…uldAlwaysRunBraveAdsService

* refactored ipfs_service h/cc * changed to use weak reference instead of base::Unretained --------- Signed-off-by: Vadym Struts <vstruts@brave.com>

Text to speech in reader mode added.

Fix writing promoCode file after Windows setup

This reverts commit c5d348b.

Vertical tab - drag&drop feature for link and text.

…20208) Revert "Hide Vertical tab strip even when it's browser fullscreen (#19802)" This reverts commit 8d1dbb9.

github-actions · 2023-09-19T13:30:50Z

components/brave_rewards/core/wallet_provider/bitflyer/connect_bitflyer_wallet.cc

-      &ConnectBitFlyerWallet::OnConnect, base::Unretained(this),
-      std::move(callback), std::move(token), std::move(address), std::string());
+  auto on_connect =
+      base::BindOnce(&ConnectBitFlyerWallet::OnConnect, base::Unretained(this),


_{reported by reviewdog 🐶}
[semgrep] base::Unretained is most of the time unrequited, and a weak reference is better suited for secure coding.
Consider swapping Unretained for a weak reference.
base::Unretained usage may be acceptable when a callback owner is guaranteed
to be destroyed with the object base::Unretained is pointing to, for example:

- PrefChangeRegistrar
- base::*Timer
- mojo::Receiver
- any other class member destroyed when the class is deallocated

Source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/client/chromium-uaf.yaml

Cc @thypon @goodov @iefremov

github-actions · 2023-09-19T13:30:50Z

components/brave_rewards/core/wallet_provider/zebpay/connect_zebpay_wallet.cc

-                     std::move(callback), std::move(access_token),
-                     std::move(deposit_id), std::string());
+  auto on_connect = base::BindOnce(
+      &ConnectZebPayWallet::OnConnect, base::Unretained(this),


_{reported by reviewdog 🐶}
[semgrep] base::Unretained is most of the time unrequited, and a weak reference is better suited for secure coding.
Consider swapping Unretained for a weak reference.
base::Unretained usage may be acceptable when a callback owner is guaranteed
to be destroyed with the object base::Unretained is pointing to, for example:

- PrefChangeRegistrar
- base::*Timer
- mojo::Receiver
- any other class member destroyed when the class is deallocated

Source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/client/chromium-uaf.yaml

Cc @thypon @goodov @iefremov

antonok-edm and others added 3 commits September 11, 2023 14:00

update adblock-rust to v0.8.1

fd31cd3

Adding New Keys for iOS Forward Navigation

26fd381

Override FormatOriginForSecurityDisplay.

2d6c2f5

Instead of overriding CreateOriginLabel just for Password Manager override FormatOriginForSecurityDisplay for global replacement of chrome:// for brave://.

zenparsing requested a review from szilardszaloki September 13, 2023 18:18

zenparsing requested a review from a team as a code owner September 13, 2023 18:18

github-actions bot assigned zenparsing Sep 13, 2023

github-actions bot reviewed Sep 13, 2023

View reviewed changes

github-actions bot added the needs-security-review label Sep 13, 2023

github-actions bot assigned goodov, iefremov and thypon Sep 13, 2023

szilardszaloki reviewed Sep 13, 2023

View reviewed changes

components/brave_rewards/core/endpoints/common/post_connect.cc Outdated Show resolved Hide resolved

szilardszaloki reviewed Sep 13, 2023

View reviewed changes

components/brave_rewards/core/wallet_provider/connect_external_wallet.cc Outdated Show resolved Hide resolved

szilardszaloki reviewed Sep 13, 2023

View reviewed changes

components/brave_rewards/core/wallet_provider/connect_external_wallet.cc Outdated Show resolved Hide resolved

Use wallet provider name on send contribution button

1d6d2ba

szilardszaloki approved these changes Sep 13, 2023

View reviewed changes

zenparsing force-pushed the ksmith-linking-country branch from a853e32 to b51b702 Compare September 13, 2023 19:53

emerick approved these changes Sep 13, 2023

View reviewed changes

zenparsing force-pushed the ksmith-linking-country branch from b51b702 to 2a25250 Compare September 14, 2023 15:01

zenparsing and others added 11 commits September 14, 2023 11:15

Merge pull request #20152 from brave/ksmith-send-tip-button

49b376e

Use wallet provider name on send contribution button

1.60.23

12cf127

fix: deposit screen performance refactor (#20144)

f016719

Merge pull request #20146 from brave/maxk-override-FormatOriginForSec…

87d2201

…urityDisplay Override FormatOriginForSecurityDisplay.

Merge pull request #20113 from brave/adblock-rust-0.8.1

b5298b4

Update adblock-rust to v0.8.1

Hide erase button when user hasnt accepted policy in AIChat (#20150)

e293e9e

fix(wallet): Swap Panel Unnecessary Scroll Bar

c573e67

fix: network filter render performance (#20171)

fc45600

Fix omnibox crash in private mode

e5f53dc

Fixes redeeming of payment tokens sometimes is not triggered with Sho…

5131158

…uldAlwaysRunBraveAdsService

Refactor IpfsService to use single ApiRequestHelper (#20089)

71a75da

* refactored ipfs_service h/cc * changed to use weak reference instead of base::Unretained --------- Signed-off-by: Vadym Struts <vstruts@brave.com>

thirumurugan-git and others added 22 commits September 18, 2023 21:38

Vertical tab - drag&drop feature for link and text.

d6b624c

Vertical tab - drag & drop - Code refactoring.

56edfc4

Vertical tab - Drop arrow implementation.

312e419

Vertical tab - Cache drop indicator images.

67f2e73

Vertical tab - Code formatting

ae5f6cf

Address lint

519554d

Build fix trial

be19f08

Vertical tab - test drag and drop changes.

c5d348b

rebase

79cae2c

1.60.34

780ad58

Merge pull request #19213 from brave/speedreader-text-to-speech

a8aeb07

Text to speech in reader mode added.

Fix writing promoCode file after Windows setup

c309026

1.60.35

866ead0

Merge pull request #20205 from brave/windows-installer-promo-fix

eee1423

Fix writing promoCode file after Windows setup

1.60.36

4b30cbb

Revert "Vertical tab - test drag and drop changes."

94908f5

This reverts commit c5d348b.

Disable tests on Windows

5f4df19

Address code review

07c7661

Merge pull request #19785 from thirumurugan-git/vtab-drag-n-drop

cc69cb1

Vertical tab - drag&drop feature for link and text.

Revert "Hide Vertical tab strip even when it's browser fullscreen" (#…

01dab7f

…20208) Revert "Hide Vertical tab strip even when it's browser fullscreen (#19802)" This reverts commit 8d1dbb9.

1.60.37

d869c88

Use geo country returned from Rewards connect endpoints

c445913

github-actions bot reviewed Sep 19, 2023

View reviewed changes

zenparsing closed this Sep 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use geo country returned from Rewards connect endpoints #20151

Use geo country returned from Rewards connect endpoints #20151

zenparsing commented Sep 13, 2023

github-actions bot Sep 13, 2023

github-actions bot Sep 19, 2023

github-actions bot Sep 19, 2023

Use geo country returned from Rewards connect endpoints #20151

Use geo country returned from Rewards connect endpoints #20151

Conversation

zenparsing commented Sep 13, 2023

Submitter Checklist:

Reviewer Checklist:

After-merge Checklist:

Test Plan:

github-actions bot Sep 13, 2023

Choose a reason for hiding this comment

github-actions bot Sep 19, 2023

Choose a reason for hiding this comment

github-actions bot Sep 19, 2023

Choose a reason for hiding this comment