Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deps to base module (Uplift to 1.59.x) #20187

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Add deps to base module (Uplift to 1.59.x) #20187

merged 1 commit into from
Sep 19, 2023

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Sep 15, 2023 •
edited by kjozwiak
Loading

Uplift of #20186
Resolves brave/brave-browser#33011

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@deeppandya deeppandya added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x86 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels Sep 15, 2023
@deeppandya deeppandya added this to the 1.59.x - Beta milestone Sep 15, 2023
@deeppandya deeppandya requested a review from a team as a code owner September 15, 2023 16:42
@deeppandya deeppandya self-assigned this Sep 15, 2023
kjozwiak
kjozwiak approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.59.x approved 👍

@kjozwiak kjozwiak merged commit aeb2f60 into 1.59.x Sep 19, 2023
5 checks passed
@kjozwiak kjozwiak deleted the vpn_android_8_issue_1.59.x branch September 19, 2023 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@deeppandya deeppandya

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Milestone
1.59.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@deeppandya @kjozwiak