Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Adding New Keys for iOS Forward Navigation (uplift to 1.58.x) #20189

Merged
merged 1 commit into from
Sep 19, 2023
Merged

[iOS] Adding New Keys for iOS Forward Navigation (uplift to 1.58.x) #20189

merged 1 commit into from
Sep 19, 2023

Conversation

soner-yuksel
Copy link
Contributor

@soner-yuksel soner-yuksel commented Sep 15, 2023 •
edited by kjozwiak
Loading

Uplift of #20134
Resolves brave/brave-browser#32946

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@soner-yuksel soner-yuksel added this to the 1.58.x - Release #3 milestone Sep 15, 2023
@soner-yuksel soner-yuksel requested a review from a team as a code owner September 15, 2023 20:39
@soner-yuksel soner-yuksel self-assigned this Sep 15, 2023
kjozwiak
kjozwiak approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.58.x approved 👍

@kjozwiak kjozwiak merged commit 7c2527e into 1.58.x Sep 19, 2023
5 checks passed
@kjozwiak kjozwiak deleted the pr20134_ios_new_navigation_key_1.58.x branch September 19, 2023 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@soner-yuksel soner-yuksel

Labels
None yet
Projects
None yet
Milestone
1.58.x - Release #4
Development

Successfully merging this pull request may close these issues.
2 participants
@soner-yuksel @kjozwiak