-
Notifications
You must be signed in to change notification settings - Fork 869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix writing promoCode file after Windows setup #20205
Conversation
4c01e29
to
4001bc8
Compare
4001bc8
to
c309026
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM after feedback and I tested out and it works great 👍 Nice work 😄
Steps I ran to test this:
This simulates the entry written by Omaha (see here for more info)
|
Verification PASSED on
I also basically went through the above using both the |
Resolves brave/brave-browser#33097
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
If using Omaha stub:
BraveBrowserSetup-BRV002.exe
)If using installer from CI build, see @bsclifton 's comment below