Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Hide Vertical tab strip even when it's browser fullscreen" #20208

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

sangwoo108
Copy link
Contributor

@sangwoo108 sangwoo108 commented Sep 19, 2023

@sangwoo108
Copy link
Contributor Author

Hi, @goodov . This would be new to you, but could you take a look at this? Simon is on PTO.

Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++
It seems Simone is on PTO this week not me :)

@sangwoo108
Copy link
Contributor Author

@simonhong Thanks! haha I thought it was you

@sangwoo108 sangwoo108 enabled auto-merge (squash) September 19, 2023 01:55
sangwoo108 pushed a commit that referenced this pull request Sep 19, 2023
sangwoo108 pushed a commit that referenced this pull request Sep 19, 2023
@sangwoo108 sangwoo108 removed the request for review from goodov September 19, 2023 09:16
@sangwoo108 sangwoo108 force-pushed the revert-19802-sko/vtab-fullscreen branch from 61dd347 to 7db9892 Compare September 19, 2023 09:19
@sangwoo108 sangwoo108 enabled auto-merge (squash) September 19, 2023 09:19
@sangwoo108 sangwoo108 merged commit 01dab7f into master Sep 19, 2023
15 checks passed
@sangwoo108 sangwoo108 deleted the revert-19802-sko/vtab-fullscreen branch September 19, 2023 12:00
@github-actions github-actions bot added this to the 1.60.x - Nightly milestone Sep 19, 2023
@kjozwiak
Copy link
Member

kjozwiak commented Sep 20, 2023

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.60.37 Chromium: 117.0.5938.88 (Official Build) nightly (64-bit)
-- | --
Revision | d869c8860226f51bdef9f6a46f18f89cd2ae656c
OS | Windows 11 Version 22H2 (Build 22621.2283)

Basically ensure that vertical tabs are visible/usable when in Fullscreen Mode using F11. On Win, there's currently no way of viewing the horizontal tabs while in Fullscreen which is known and will be addressed in another fix.

  • ensured that vertical tabs are visible and usable while you're in Fullscreen Mode

image


Verification PASSED on macOS 13.5.2 x64 Ventura using the following build(s):

Brave | 1.60.38 Chromium: 117.0.5938.88 (Official Build) nightly (x86_64)
--- | ---
Revision | 89f7ea7a01a3ab15163916a9441c473ab1021372
OS | macOS Version 13.5.2 (Build 22G91)

Basically ensure that vertical tabs are visible/usable when in Fullscreen Mode using fn + f. Also ensured that horizontal tabs are also visible/usable as per the following:

Example Example
Screenshot 2023-09-19 at 9 25 58 PM Screenshot 2023-09-19 at 9 30 17 PM

kjozwiak pushed a commit that referenced this pull request Sep 20, 2023
kjozwiak pushed a commit that referenced this pull request Sep 20, 2023
…plift to 1.58.x) (#20210)

Uplift of #20208 (squashed) to release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

revert hide vertical tab strip in full screen from 1.58.x Vertical tabs disapear in full screen macOS
3 participants