Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes redeeming of payment tokens sometimes is not triggered with ShouldAlwaysRunBraveAdsService - 1.59.x #20217

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Fixes redeeming of payment tokens sometimes is not triggered with ShouldAlwaysRunBraveAdsService - 1.59.x #20217

merged 1 commit into from
Sep 19, 2023

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Sep 19, 2023 •
edited by kjozwiak
Loading

Uplift of #20176
Resolves brave/brave-browser#32991

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey tmancey added this to the 1.59.x - Beta milestone Sep 19, 2023
@tmancey tmancey requested a review from a team as a code owner September 19, 2023 13:52
@tmancey tmancey self-assigned this Sep 19, 2023
kjozwiak
kjozwiak approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.59.x approved 👍 QA has verified the PR on Nightly as per #20176 (comment).

@kjozwiak kjozwiak merged commit eebf56d into 1.59.x Sep 19, 2023
14 checks passed
@kjozwiak kjozwiak deleted the issues/32991-1.59.x branch September 19, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@tmancey tmancey

Labels
None yet
Projects
None yet
Milestone
1.59.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@tmancey @kjozwiak