Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update indexmap to 1.9 and remove hashbrown 0.11 #20221

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Update indexmap to 1.9 and remove hashbrown 0.11 #20221

merged 2 commits into from
Oct 3, 2023

Conversation

rillian
Copy link
Contributor

@rillian rillian commented Sep 19, 2023 •
edited
Loading

Indexmap should be the only dep change needed to remove the older copy of hashbrown in favor of v0.12.

Resolves brave/brave-browser#33121

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@rillian rillian self-assigned this Sep 19, 2023
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Sep 19, 2023
@rillian
Copy link
Contributor Author

rillian commented Sep 19, 2023

Marking as a draft for now. I'm getting a bunch of missing feature issues with chromium-side crates, so I may have messed something up.

  • itoa v0.4 needs std
  • rand needs small_rng
  • syn needs fold

Base automatically changed from cr118 to master September 27, 2023 15:50
@rillian
Update indexmap dep to 1.9.3
d5e87cd 
Move to the most recent 1.9.x release of the `indexmap` rust crate
so we don't have any dependency on `hashbrown` 0.11. All other
code is compatible with hashbrown 0.22.
@rillian
Remove hashbrown 0.11 dep
44eb43d 
This is no longer used; everything is compatible with hashbrown 0.12.

Resolves brave/brave-browser#33121
@rillian
Copy link
Contributor Author

rillian commented Sep 27, 2023

Rebased now that cr118 has landed. Green on CI and local build, so I think this is ready for review.

@rillian rillian marked this pull request as ready for review September 27, 2023 20:27
@rillian rillian requested review from a team and bridiver as code owners September 27, 2023 20:27
@rillian rillian merged commit 60a3f2e into master Oct 3, 2023
18 checks passed
@rillian rillian deleted the indexmap-1.9.3 branch October 3, 2023 15:19
@github-actions github-actions bot added this to the 1.60.x - Nightly milestone Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridiver bridiver bridiver approved these changes

Assignees

@rillian rillian

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps)
Projects
None yet
Milestone
1.60.x - Release
Development

Successfully merging this pull request may close these issues.

Update indexmap and remove hashbrown 0.11
2 participants
@rillian @bridiver