Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Brave vpn on beta & nightly (uplift to 1.61.x) #20974

Closed
wants to merge 1 commit into from
Closed

Enable Brave vpn on beta & nightly (uplift to 1.61.x) #20974

wants to merge 1 commit into from

Conversation

brave-builds
Copy link
Collaborator

Uplift of #20939
Resolves brave/brave-browser#34230

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner November 14, 2023 17:11
@brave-builds brave-builds self-assigned this Nov 14, 2023
@brave-builds brave-builds added this to the 1.61.x - Beta milestone Nov 14, 2023
kjozwiak
kjozwiak reviewed Dec 21, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing as the above isn't valid anymore. @Uni-verse running through #20939 (comment) on Nightly via 1.63.x and then will run through the same cases on BETA via 1.62.x. Closing the following uplift PR.

@kjozwiak kjozwiak closed this Dec 21, 2023
@kjozwiak kjozwiak deleted the pr20939_enable_vpn_beta_nightly_1.61.x branch December 21, 2023 21:12
@kjozwiak kjozwiak removed this from the 1.61.x - Release #6 milestone Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brave-builds @kjozwiak