Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Brave News]: Better offline handling & UX tweaks #21507

Merged
merged 8 commits into from
Jan 10, 2024
Merged

[Brave News]: Better offline handling & UX tweaks #21507

merged 8 commits into from
Jan 10, 2024

Commits on Jan 10, 2024

  1. Add observer

    @fallaciousreasoning
    fallaciousreasoning committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    dd0ce68 View commit details
    Browse the repository at this point in the history

  2. Fix loading spinner background

    @fallaciousreasoning
    fallaciousreasoning committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    f20d88b View commit details
    Browse the repository at this point in the history

  3. Refetch publishers, if required on network acquired

    @fallaciousreasoning
    fallaciousreasoning committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    9259b8c View commit details
    Browse the repository at this point in the history

  4. Add the start of error handling

    @fallaciousreasoning
    fallaciousreasoning committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    31e999f View commit details
    Browse the repository at this point in the history

  5. Show errors from service

    @fallaciousreasoning
    fallaciousreasoning committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    f5351ec View commit details
    Browse the repository at this point in the history

  6. Show not connected error 

    Don't try and generate the feed when we have no items
    @fallaciousreasoning
    fallaciousreasoning committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    eae49af View commit details
    Browse the repository at this point in the history

  7. Hide sections when empty

    @fallaciousreasoning
    fallaciousreasoning committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    ba54d20 View commit details
    Browse the repository at this point in the history

  8. Changes for PR

    @fallaciousreasoning
    fallaciousreasoning committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    32d01e7 View commit details
    Browse the repository at this point in the history