Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Brave News]: Tweaks round 5 (#21516) #21554

Merged
merged 1 commit into from
Jan 14, 2024
Merged

[Brave News]: Tweaks round 5 (#21516) #21554

merged 1 commit into from
Jan 14, 2024

Conversation

fallaciousreasoning
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning commented Jan 11, 2024

@fallaciousreasoning fallaciousreasoning requested a review from a team as a code owner January 11, 2024 23:32
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jan 11, 2024
@kjozwiak kjozwiak added this to the 1.62.x - Beta milestone Jan 12, 2024
* Migrate article channel names

Hide sidebar on small screens

PoC sidebar

Lazy load sidebar

Fix background

Fix ad link

Add articles with no images

Create top bar

Styling improvements

Sidebar color tweaks

Sidebar color tweaks

Make buttons nicer

* Same top level headings

* Remove sidebar title

* Monochrome news icon on peeking card

* Fix peek button not showing on empty feeds

* Heading cleanup
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.62.x approved 👍 QA has verified the PR on Nightly using 1.63.x as per #21516 (comment).

@kjozwiak kjozwiak merged commit a1313ea into 1.62.x Jan 14, 2024
13 checks passed
@kjozwiak kjozwiak deleted the bn-tweaks-5-1.62 branch January 14, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants