Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Web Discovery reporting & double fetching #24971

Open
wants to merge 4 commits into
base: wdp-native-extraction-payload-gen
Choose a base branch
from

Conversation

DJAndries
Copy link
Collaborator

Resolves brave/brave-browser#39439

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Copy link
Member

@fmarier fmarier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

script/brave_license_helper.py change 👍

@DJAndries DJAndries requested review from simonhong and a team as code owners October 25, 2024 01:51
@DJAndries DJAndries force-pushed the wdp-native-extraction-payload-gen branch from 3e0c02c to 0d8c383 Compare October 25, 2024 01:51
Copy link
Collaborator

@cdesouza-chromium cdesouza-chromium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. I'm leaving some comments for now. I'll carry on with the review once after we go over these ones first.

components/web_discovery/browser/double_fetcher.cc Outdated Show resolved Hide resolved
components/web_discovery/browser/request_queue.cc Outdated Show resolved Hide resolved
components/web_discovery/browser/double_fetcher.cc Outdated Show resolved Hide resolved
components/web_discovery/browser/ecdh_aes.cc Outdated Show resolved Hide resolved
components/web_discovery/browser/ecdh_aes.cc Outdated Show resolved Hide resolved
components/web_discovery/browser/ecdh_aes.cc Outdated Show resolved Hide resolved
components/web_discovery/browser/ecdh_aes.cc Outdated Show resolved Hide resolved
components/web_discovery/browser/ecdh_aes.cc Outdated Show resolved Hide resolved
components/web_discovery/browser/ecdh_aes.cc Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants