-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Web Discovery reporting & double fetching #24971
base: wdp-native-extraction-payload-gen
Are you sure you want to change the base?
Conversation
4b7529f
to
4213a66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
script/brave_license_helper.py
change 👍
37e3465
to
113579d
Compare
4213a66
to
07bdd3d
Compare
113579d
to
20fe6f6
Compare
07bdd3d
to
3e0c02c
Compare
20fe6f6
to
2d1b41b
Compare
2d1b41b
to
3e62811
Compare
3e0c02c
to
0d8c383
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR. I'm leaving some comments for now. I'll carry on with the review once after we go over these ones first.
0d8c383
to
2d821db
Compare
2dda0ba
to
aab44a2
Compare
2d821db
to
cea7261
Compare
aab44a2
to
83195a9
Compare
Resolves brave/brave-browser#39439
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: