Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SidePanel: fixes button pressed state. (uplift to 1.72.x) #25942

Merged
merged 5 commits into from
Oct 25, 2024
Merged

SidePanel: fixes button pressed state. (uplift to 1.72.x) #25942

merged 5 commits into from
Oct 25, 2024

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Oct 11, 2024 •
edited by LaurenWags
Loading

Uplift of #25679
Uplift of #25771
Uplift of #26056
Uplift of #26132
Uplift of #26194

Resolves brave/brave-browser#41154
Resolves brave/brave-browser#41342 (prepare for cr131 in advance, cr131 depends on this change)
Resolves brave/brave-browser#41748 (regression from 41342)
Resolves brave/brave-browser#41782 (regression from 41342)
Resolves brave/brave-browser#41860 (regression from 41342)

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner October 11, 2024 05:40
@brave-builds brave-builds requested a review from a team October 11, 2024 05:40
@brave-builds brave-builds added this to the 1.72.x - Beta milestone Oct 11, 2024
@brave-builds brave-builds self-assigned this Oct 11, 2024
@simonhong simonhong force-pushed the pr25679_maxk-side-panel-fixes_1.72.x branch from 8a69005 to ecdc012 Compare October 11, 2024 07:57
@simonhong simonhong self-assigned this Oct 18, 2024
@simonhong
Merge pull request #26056 from brave/sidebar_deprecate_OnEntryWillDer…
0013246 
…egister

Removed using SidePanelCoordinator::OnEntryWillDeregister
@simonhong
Merge pull request #26132 from brave/fix_sidebar_item_activation_state
9e6b85d 
Fixed contextual panel item is not activated after attaching to window
@simonhong
Merge pull request #26194 from brave/fix_sidebar_asan_failure
68f54aa 
Fixed sidebar asan failure when closing browser window
@simonhong simonhong force-pushed the pr25679_maxk-side-panel-fixes_1.72.x branch from cf27f29 to 68f54aa Compare October 25, 2024 05:16
LaurenWags
LaurenWags approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@LaurenWags LaurenWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 1.72.x is approved 👍🏻 QA has verified the PR using 1.73.x/Nightly as per #25679 (comment), #25771 (comment), and #26132 (comment).

@LaurenWags LaurenWags merged commit 8468097 into 1.72.x Oct 25, 2024
15 checks passed
@LaurenWags LaurenWags deleted the pr25679_maxk-side-panel-fixes_1.72.x branch October 25, 2024 16:09
@brave-builds
Copy link
Collaborator Author

Released in v1.72.89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurenWags LaurenWags LaurenWags approved these changes

Assignees

@simonhong simonhong

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.72.x - Beta
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @LaurenWags @kjozwiak @simonhong