Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return IDS_WALLET_INVALID_PARAMETERS if duplicate NFT IDs are passed to JsonRpcService::GetNftMetadatas #26171

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

nvonpentz
Copy link
Member

@nvonpentz nvonpentz commented Oct 23, 2024

Resolves brave/brave-browser#41829
iOS side fix to stop sending duplicate NFT IDs #26174
cc @nuo-xu

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

for (const auto& nft : nft_identifiers) {
// Create a unique string identifier combining contract, token id, and chain
std::string unique_id =
nft->contract_address + "_" + nft->token_id + "_" + nft->chain_id;
Copy link
Member

@yrliou yrliou Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

base::StrCat

Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with one minor comment above

@github-actions github-actions bot added the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Oct 28, 2024
@github-actions github-actions bot removed the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Oct 28, 2024
Copy link
Contributor

The following commits were not verified:
1abcefe (unknown_key)
09572d7 (unknown_key)
113b3d2 (unknown_key)
90695ca (unknown_key)

@nvonpentz nvonpentz enabled auto-merge (squash) October 28, 2024 17:43
@nvonpentz nvonpentz merged commit 8fbee3c into master Oct 28, 2024
17 checks passed
@nvonpentz nvonpentz deleted the nft-metadata-api-fix branch October 28, 2024 18:47
@github-actions github-actions bot added this to the 1.73.x - Nightly milestone Oct 28, 2024
@brave-builds
Copy link
Collaborator

Released in v1.73.54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when fetching NFT metadata
3 participants