Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve contrast for pinned tabs outline #26213

Closed
wants to merge 37 commits into from
Closed

Conversation

aguscruiz
Copy link
Collaborator

@aguscruiz aguscruiz commented Oct 24, 2024

Resolves brave/brave-browser#41720

Current pinned tabs outline color:

image image

New pinned tabs outline color:

image image

Current active state for tabs (release):

image

New active state for tabs:

image

Current active state for tabs (release - not visible):

image

New hover state for tabs:

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@github-actions github-actions bot added the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Oct 24, 2024
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

wknapik and others added 24 commits October 24, 2024 23:44
* Shred private WKWebsiteDataStore data types.

* review(kylehickinson): include _WKWebsiteDataTypeSearchFieldRecentSearches on iOS 16.
Fixes possible crash when parsing NTT Sponsored Images component resource
fix brave/brave-browser#41860

When global panel is shown by deregistering contextual panel,
SidebarContainerView should stop observing that entry.
[ads] Fixes empty device id on Linux
Fixed sidebar asan failure when closing browser window
The use of `base::FilePath` in `TorConfig` could be a serious source for
a vulnerability if someone got control of the browser process. This
change employs the use of `SafeBaseName`, which only allows for the base
component of a path. With this browser process and the tor launcher do
agree over a certain definition of how the files are discovered.

Resolves brave/brave-browser#41834
#26195)

* [Android] Select the highest priority threat from SafetyNetClient.lookupUri response
fixes brave/brave-browser#41581
---------
Co-authored-by: Francois Marier <francois@brave.com>
Fix crash when dismissing NTP news opt-in.
Resolve an issue with automatic flag for timezone
…_option_ui

Update server selection settings option UI
Remove Greaselion dependency from Rewards service (v2)
Brandon-T and others added 11 commits October 25, 2024 17:47
…#26226)

* Fix History and Bookmarks and ShieldsPanel and 3-dot menu
* Remove NOTREACHED_IN_MIGRATION for iOS. Replaced with CHECK, DCHECK, [[no_return]] where necessary.
Change LazyVStack to VStack to see if it helps.
[ads] Fixes System Notification ad is clicked and dismissed at the same time on Linux
[ads] Fixes earnings in rewards non-custodian state count towards earnings in rewards custodian state
@aguscruiz aguscruiz requested review from a team as code owners October 27, 2024 23:25
@github-actions github-actions bot added CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/storybook-url Deploy storybook and provide a unique URL for each build CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch and removed chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch labels Oct 27, 2024
Copy link
Contributor

[puLL-Merge] - brave/brave-core@26213

Description

This PR makes several changes across the codebase, primarily focused on implementing a new creator detection feature for Brave Rewards, updating various components, and making improvements to the search functionality on the New Tab Page. The changes also include some security improvements and bug fixes.

Possible Issues

  1. The removal of Greaselion-related code might affect existing functionality that depends on it.
  2. The changes to the Tor client updater and launcher might introduce new edge cases or security considerations.
  3. The new creator detection feature might have performance implications on certain websites.

Security Hotspots

  1. Changes to the Tor client updater and launcher (components/tor/) should be carefully reviewed for potential security implications.
  2. Modifications to the Safe Browsing API handler (components/safe_browsing/) need to be scrutinized for any potential weaknesses in threat detection.
Changes

Changes

  1. browser/brave_rewards/:

    • Implemented a new creator detection feature for media platforms.
    • Removed Greaselion-related code and dependencies.
    • Updated reward service to use the new creator detection mechanism.
  2. components/brave_rewards/:

    • Added new files for creator detection scripts.
    • Updated publisher utils to support the new creator detection feature.
  3. components/tor/:

    • Refactored the Tor client updater and launcher.
    • Added new constants and utility functions for Tor paths.
  4. components/safe_browsing/:

    • Updated the Safe Browsing API handler to support multiple threats.
    • Implemented a priority system for handling multiple threats.
  5. brave-ios/:

    • Made improvements to URL display and handling in various parts of the iOS app.
    • Updated the bookmarks and history views.
  6. New Tab Page:

    • Implemented a new search engine context provider.
    • Updated the search box functionality on the New Tab Page.
  7. Various other updates and improvements across the codebase, including version bumps and minor bug fixes.

  8. Updated test files and performance profiles.

Overall, this PR represents a significant update to the Brave browser, with a focus on improving the Rewards system, search functionality, and security features.

@aguscruiz aguscruiz closed this Oct 28, 2024
@aguscruiz aguscruiz deleted the theme-contrast branch October 28, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) CI/storybook-url Deploy storybook and provide a unique URL for each build puLL-Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pinned tabs in vertical view are not visually separated from non-pinned tabs