-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve contrast for pinned tabs outline #26213
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* Shred private WKWebsiteDataStore data types. * review(kylehickinson): include _WKWebsiteDataTypeSearchFieldRecentSearches on iOS 16.
Fixes possible crash when parsing NTT Sponsored Images component resource
fix brave/brave-browser#41860 When global panel is shown by deregistering contextual panel, SidebarContainerView should stop observing that entry.
[ads] Fixes empty device id on Linux
Fixed sidebar asan failure when closing browser window
The use of `base::FilePath` in `TorConfig` could be a serious source for a vulnerability if someone got control of the browser process. This change employs the use of `SafeBaseName`, which only allows for the base component of a path. With this browser process and the tor launcher do agree over a certain definition of how the files are discovered. Resolves brave/brave-browser#41834
#26195) * [Android] Select the highest priority threat from SafetyNetClient.lookupUri response fixes brave/brave-browser#41581 --------- Co-authored-by: Francois Marier <francois@brave.com>
Resolve format error
Resolve format issue
Fix crash when dismissing NTP news opt-in.
Resolve an issue with automatic flag for timezone
…_option_ui Update server selection settings option UI
Remove Greaselion dependency from Rewards service (v2)
…nings in rewards custodian state
…#26226) * Fix History and Bookmarks and ShieldsPanel and 3-dot menu
* Remove NOTREACHED_IN_MIGRATION for iOS. Replaced with CHECK, DCHECK, [[no_return]] where necessary.
Change LazyVStack to VStack to see if it helps.
[ads] Fixes System Notification ad is clicked and dismissed at the same time on Linux
[ads] Fixes earnings in rewards non-custodian state count towards earnings in rewards custodian state
…into theme-contrast
[puLL-Merge] - brave/brave-core@26213 DescriptionThis PR makes several changes across the codebase, primarily focused on implementing a new creator detection feature for Brave Rewards, updating various components, and making improvements to the search functionality on the New Tab Page. The changes also include some security improvements and bug fixes. Possible Issues
Security Hotspots
ChangesChanges
Overall, this PR represents a significant update to the Brave browser, with a focus on improving the Rewards system, search functionality, and security features. |
Resolves brave/brave-browser#41720
Current pinned tabs outline color:
New pinned tabs outline color:
Current active state for tabs (release):
New active state for tabs:
Current active state for tabs (release - not visible):
New hover state for tabs:
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: