feat(wallet): Shield ZCash Account Modal

[Douglashdaniel]

Description

Introduces the ability to Shield a ZCash Account on the Accounts page.

Resolves brave/brave-browser#41780

Submitter Checklist:

• I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally:
  • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
  • npm run presubmit wiki, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

1. Make sure that ZCash Shielded Transactions` is enabled
2. Open the Wallet and navigate to the Accounts tab
3. Click on the More Menu for you ZCash Account
4. Click on Switch to shielded account
5. Now click Shield account
6. If successful you should now see a Shielded label next to your Account Name.

Screen.Recording.5.mov

[brave-builds]

A Storybook has been deployed to preview UI for the latest push

[cypt4]

++

[cypt4]

nit: zcash

[cypt4]

I think it is better to use zcash instead of zCash like in other places

[onyb]

++

[nuo-xu]

iOS++

[github-actions]

[puLL-Merge] - brave/brave-core@26214

Description

This PR adds support for ZCash shielded transactions in the Brave Wallet. It introduces new UI elements and functionality to allow users to upgrade their ZCash accounts to shielded accounts, which provide enhanced privacy for transactions.

Changes

Changes

1. browser/ui/webui/brave_wallet/common_handler/wallet_handler.cc:

   • Added IsZCashShieldedTransactionsEnabled() to the WalletInfo struct.

2. components/brave_wallet/browser/brave_wallet_constants.h:

   • Added new localized strings for ZCash shielded transactions.

3. components/brave_wallet/common/brave_wallet.mojom:

   • Added is_z_cash_shielded_transactions_enabled to the WalletInfo struct.

4. components/brave_wallet_ui/common/selectors/wallet-selectors.ts:

   • Added a selector for isZCashShieldedTransactionsEnabled.

5. components/brave_wallet_ui/common/slices/wallet.slice.ts:

   • Added isZCashShieldedTransactionsEnabled to the wallet state.

6. components/brave_wallet_ui/components/desktop/account-list-item/index.tsx:

   • Updated to display a "Shielded" label for shielded ZCash accounts.
   • Added logic to show the shield account modal.

7. components/brave_wallet_ui/components/desktop/popup-modals/shield_zcash_account/:

   • Added new components for the shield ZCash account modal.

8. components/brave_wallet_ui/components/desktop/wallet-menus/account-actions-menu.tsx:

   • Added support for the "Shield" action in the account menu.

9. components/brave_wallet_ui/constants/types.ts:

   • Added isZCashShieldedTransactionsEnabled to the WalletState interface.
   • Added shield to AccountModalTypes.

10. components/brave_wallet_ui/options/account-list-button-options.ts:

    • Added a new option for shielding ZCash accounts.

11. components/brave_wallet_ui/stories/locale.ts:

    • Added new localized strings for ZCash shielded transactions.

12. components/resources/wallet_strings.grdp:

    • Added new string resources for ZCash shielded transactions.

Possible Issues

• The PR doesn't include any tests for the new functionality, which could lead to potential bugs or regressions.
• The implementation assumes that the backend support for ZCash shielded transactions is already in place, which may not be the case if this is part of a larger feature rollout.

Security Hotspots

No significant security hotspots were identified in this change. However, as this feature deals with privacy-enhancing functionality for cryptocurrency transactions, it's crucial that the implementation correctly handles the shielding process and doesn't inadvertently expose sensitive information.

[petemill]

strings look good

[brave-builds]

Released in v1.73.62