Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf tests: move setup android step from devops #26221

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

atuchin-m
Copy link
Collaborator

@atuchin-m atuchin-m commented Oct 25, 2024

Resolves brave/brave-browser#41880
The PR:

  • move devops part to setup android device to b-c
  • make a dedicated file to be pushed and launched instead of one-liner. If the script fails the build is considered as broken.
  • add a step to unlock device after rebooting
  • reboot the device by default of CI and optionally for a local run

Verified here: https://ci.brave.com/job/brave-browser-test-perf-android/1142/console

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@atuchin-m atuchin-m self-assigned this Oct 25, 2024
@atuchin-m atuchin-m requested a review from goodov October 28, 2024 08:50
Copy link
Member

@goodov goodov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with one nit


from components.perf_test_utils import GetProcessOutput
import components.path_util as path_util


def RunFromRoot(cmd: str) -> bool:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RunAsRoot

"FromRoot" sounds like running from the root directory: /.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed.

@atuchin-m atuchin-m force-pushed the move-setup-android-to-b-c-from-devops branch from 6a49901 to 82f7d7d Compare October 28, 2024 11:19
@atuchin-m atuchin-m enabled auto-merge (squash) October 28, 2024 12:20
@atuchin-m atuchin-m merged commit d0e69ce into master Oct 28, 2024
18 of 19 checks passed
@atuchin-m atuchin-m deleted the move-setup-android-to-b-c-from-devops branch October 28, 2024 12:24
@github-actions github-actions bot added this to the 1.73.x - Nightly milestone Oct 28, 2024
@brave-builds
Copy link
Collaborator

Released in v1.73.53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Perf tests: move the script to setup android from devops to brave-core to fix CI
4 participants